Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Repair Alert Flyout #73528

Merged
merged 10 commits into from
Jul 30, 2020
Merged

[Uptime] Repair Alert Flyout #73528

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f68e77f
Add await to promise.
justinkambic Jul 28, 2020
f5e2705
Remove lazy loading and reference to lazy resource from validation.
justinkambic Jul 28, 2020
5d12093
Merge branch 'master' into uptime_repair-alert-flyout
justinkambic Jul 29, 2020
8d24ff4
Revert previous changes and add simpler fix.
justinkambic Jul 29, 2020
5f23388
Remove unnecessary formatting changes.
justinkambic Jul 29, 2020
bec3f0c
Further cleanup.
justinkambic Jul 29, 2020
b1b8b78
Add more descriptive import path.
justinkambic Jul 29, 2020
20d8114
Merge branch 'master' into uptime_repair-alert-flyout
shahzad31 Jul 30, 2020
bbe0372
fix type
shahzad31 Jul 30, 2020
38b7925
fix type
shahzad31 Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/uptime/public/lib/alert_types/lazy_wrapper/validate_monitor_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
AtomicStatusCheckParamsType,
MonitorAvailabilityType,
StatusCheckParamsType,
} from '../../../../common/runtime_types/alerts';
} from '../../../../common/runtime_types';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will also need to revert this, actually when you import it from index.ts file, it ends up bundling everything from that index file into the imported bundle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I had consider reverting it and didn't think it would impact. I was wrong! Fixed this in b1b8b78.

import { ValidationResult } from '../../../../../triggers_actions_ui/public';

export function validateMonitorStatusParams(alertParams: any): ValidationResult {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const initMonitorStatusAlertType: AlertTypeInitializer = ({
validateFunc = validateMonitorStatusParams;
})();
}
return validateFunc && validateFunc(alertParams);
return validateFunc ? validateFunc(alertParams) : {};
},
defaultActionMessage,
requiresAppContext: false,
Expand Down