[Uptime] Reduce miscellaneous uptime bundle size #70632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
shahzad31
added
v7.1.0
v7.9.0
v8.0.0
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
mikecote
approved these changes
Jul 16, 2020
justinkambic
approved these changes
Jul 27, 2020
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jul 29, 2020
Co-authored-by: Elastic Machine <[email protected]>
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
shahzad31
added a commit
that referenced
this pull request
Jul 30, 2020
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> Co-authored-by: Justin Kambic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#232
This PR reduces uptime page load bundle size by introducing lazy loading for dependent code
Ultimate dependent diagram looks like this for uptime.plugin.js bundle. Bundle size get's reduced by 95%.
Testing
This doesn't change any functionality or tests, few things to look out for, make sure, uptime data is displayed on obsv overview page. User can edit alerts from alerting app.
Uptime works as expected.
Testing Bundle Size
Create webpack stats
node scripts/build_kibana_platform_plugins.js --no-core --no-examples --profilewith and without --distFind the Uptime bundle in
x-pack/plugins/apm/target/public/uptime.plugin.js. This should be as small as possible.Analyze
x-pack/plugins/uptime/target/public/stats.jsonfile using one of the two:upload stats.json to chrisbateman.github.io/webpack-visualizer
run npx webpack-bundle-analyzer x-pack/plugins/apm/target/public/stats.jsonThis PR was inspired by #67654