[SIEM] [Security] unified code structure phase 0

[XavierM]

Summary

This PR is to allow our family to get bigger and to have a better dev experience in our security code structure. Instead, to have as the upper-level components/containers/pages/store etc, we wanted to have the area on the top level like hosts/network/cases/timelines/alerts -> components/containers/pages/store etc...

We call this phase 0 because we just wanted to move the file around where it makes the most sense. The next phase will be to clean up more the dependencies between the sub-plugins. This PR was just tedious because of moving all the files and fixing the imports. Thanks To @patrykkopycinski and @cnasikas for the big help.

Reviewer instructions

Note: there are too many files changed in this branch for GitHub to present a nice diff. Instead, you'll have to review this locally:

# configure kibana repo to track renames across lots of files (this is what GitHub isn't doing)
git config diff.renamelimit 2600

# check out the branch locally
git fetch origin refs/pull/65965/head
git checkout -b XavierM/security-structure-2 FETCH_HEAD

# to view the full diff against master:
git diff $(git merge-base head master)

# to view a single file's history:
git log -p --follow -- <path-to-file>

[rylnd]

Just a quick comment: it does look like this inflates siem's initial bundle pretty significantly (2MB up from 200kB) :

I think we can fix it after this gets merged, but there's also a quick, naive fix for this branch if you want it:

diff --git a/x-pack/plugins/siem/public/plugin.tsx b/x-pack/plugins/siem/public/plugin.tsx
index 1a76e52c98..cc46025ddc 100644
--- a/x-pack/plugins/siem/public/plugin.tsx
+++ b/x-pack/plugins/siem/public/plugin.tsx
@@ -33,12 +33,6 @@ import { APP_ID, APP_NAME, APP_PATH, APP_ICON } from '../common/constants';
 import { initTelemetry } from './common/lib/telemetry';
 import { KibanaServices } from './common/lib/kibana/services';
 import { serviceNowActionType, jiraActionType } from './common/lib/connectors';
-import { Cases } from './cases';
-import { Alerts } from './alerts';
-import { Hosts } from './hosts';
-import { Network } from './network';
-import { Overview } from './overview';
-import { Timelines } from './timelines';
 
 export interface SetupPlugins {
   home: HomePublicPluginSetup;
@@ -68,12 +62,6 @@ export interface PluginStart {}
 
 export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, StartPlugins> {
   private kibanaVersion: string;
-  private readonly alertsSubPlugin = new Alerts();
-  private readonly casesSubPlugin = new Cases();
-  private readonly hostsSubPlugin = new Hosts();
-  private readonly networkSubPlugin = new Network();
-  private readonly overviewSubPlugin = new Overview();
-  private readonly timelinesSubPlugin = new Timelines();
 
   constructor(initializerContext: PluginInitializerContext) {
     this.kibanaVersion = initializerContext.env.packageInfo.version;
@@ -108,12 +96,19 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
         security: plugins.security,
       } as StartServices;
 
-      const alertsStart = this.alertsSubPlugin.start();
-      const casesStart = this.casesSubPlugin.start();
-      const hostsStart = this.hostsSubPlugin.start();
-      const networkStart = this.networkSubPlugin.start();
-      const overviewStart = this.overviewSubPlugin.start();
-      const timelinesStart = this.timelinesSubPlugin.start();
+      const alertsSubPlugin = new (await import('./alerts')).Alerts();
+      const casesSubPlugin = new (await import('./cases')).Cases();
+      const hostsSubPlugin = new (await import('./hosts')).Hosts();
+      const networkSubPlugin = new (await import('./network')).Network();
+      const overviewSubPlugin = new (await import('./overview')).Overview();
+      const timelinesSubPlugin = new (await import('./timelines')).Timelines();
+
+      const alertsStart = alertsSubPlugin.start();
+      const casesStart = casesSubPlugin.start();
+      const hostsStart = hostsSubPlugin.start();
+      const networkStart = networkSubPlugin.start();
+      const overviewStart = overviewSubPlugin.start();
+      const timelinesStart = timelinesSubPlugin.start();
 
       return renderApp(services, params, {
         routes: [

[rylnd]

@elasticmachine merge upstream

[rylnd]

Checked it out locally, ran through some standard desk tests. Did not check every single line of code, but I did page through the entirety of it with git diff $(git merge-base master head) -w --word-diff=color to see if there were any large logical changes: besides the top-level restructuring, things looked pretty mechanical/straightforward.

I was not able to find any issues with my desk testing, and once CI is green I think that'll give us enough confidence to merge this now and fix any outstanding issues between now and release.

This new structure is going to be really nice moving forward; thank you for taking the time to do this @XavierM 🥇

[rylnd]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 08a5ab8

History

• 💔 Build #47150 failed 0765937
• 💔 Build #47117 failed d784e05
• 💔 Build #47136 failed c2b9e1e
• 💔 Build #46971 failed 39bed1b
• 💔 Build #46808 failed 39bed1b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[oatkiller]

Thank you! Pumped to work together more.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[tonymeehan]

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)