Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Organize layers into subfolders #65513

Merged
merged 13 commits into from
May 12, 2020

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented May 6, 2020

Organizes all layer implementations into their own folders.

For clarity, this renames the existing layers folder to classes.

$ pwd
.../kibana/x-pack/plugins/maps/public/classes/layers
$ tree
.
├── blended_vector_layer
│   └── blended_vector_layer.ts
├── heatmap_layer
│   └── heatmap_layer.js
├── layer.tsx
├── layer_wizard_registry.ts
├── load_layer_wizards.ts
├── solution_layers
│   └── observability
│       ├── create_layer_descriptor.test.ts
│       ├── create_layer_descriptor.ts
│       ├── display_select.tsx
│       ├── index.ts
│       ├── layer_select.tsx
│       ├── metric_select.tsx
│       ├── observability_layer_template.tsx
│       └── observability_layer_wizard.tsx
├── tile_layer
│   ├── tile_layer.d.ts
│   ├── tile_layer.js
│   └── tile_layer.test.ts
├── tiled_vector_layer
│   └── tiled_vector_layer.tsx
├── vector_layer
│   ├── vector_layer.d.ts
│   └── vector_layer.js
└── vector_tile_layer
    └── vector_tile_layer.js

todo:

  • fix unit tests
  • fix functional tests

Sorry, something went wrong.

@thomasneirynck thomasneirynck added chore WIP Work in progress [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.9.0 labels May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2020
@thomasneirynck thomasneirynck marked this pull request as ready for review May 7, 2020 14:08
@thomasneirynck thomasneirynck requested review from a team as code owners May 7, 2020 14:08
@thomasneirynck thomasneirynck requested review from nreese and kindsun May 7, 2020 14:08
@thomasneirynck thomasneirynck removed the WIP Work in progress label May 7, 2020
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, a few SCSS files moved around. LGTM! 🎉

@nreese
Copy link
Contributor

nreese commented May 7, 2020

Lots of import reach very deep into folders. What do you think about exporting everything from layers/index.ts so that imports do not need to go so deep into the layers folder?

@thomasneirynck
Copy link
Contributor Author

Lots of import reach very deep into folders. What do you think about exporting everything from layers/index.ts so that imports do not need to go so deep into the layers folder?

agreed that this should be made more convenient for client-devs. I'd suggest doing this in another PR, e.g. when working on public API extension points for layers and sources. Right now, this is all internal code, and would just introduce more files and indirection.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI
code review

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit bf178de into elastic:master May 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 12, 2020
* master: (46 commits)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854)
  [functional/services] import By/until from module (elastic#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676)
  Inspect action shows on dashboard for every chart (elastic#65998)
  Fix heigt calc in calc issue for ie11 (elastic#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028)
  [SIEM] [Security] unified code structure phase 0 (elastic#65965)
  [Maps] Organize layers into subfolders (elastic#65513)
  skip flaky suite (elastic#59849)
  Cleanup prefill and edit flow. (elastic#66105)
  Fix major severity service map ring colors (elastic#66124)
  [DOCS] Improves formatting in action types (elastic#65932)
  [DOCS] APM Agent config: Setting values must be string (elastic#65875)
  Change default cert age limit value. (elastic#65918)
  [DOCS] Removed saved object options (elastic#66072)
  [SIEM] [Cases] Case API tests (elastic#65777)
  Add example of of local plugin installation (elastic#65986)
  skip flaky suite (elastic#65741)
  [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583)
  [Reporting/Test] Add Functional test for download CSV (elastic#65401)
  ...
jloleysens added a commit that referenced this pull request May 12, 2020
…ine-editor

* 'master' of github.com:elastic/kibana: (37 commits)
  [APM] Correct relative paths in scripts (#66159)
  [Uptime] Enable deselection of stale filters (#65523)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854)
  [functional/services] import By/until from module (#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (#65676)
  Inspect action shows on dashboard for every chart (#65998)
  Fix heigt calc in calc issue for ie11 (#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (#66028)
  [SIEM] [Security] unified code structure phase 0 (#65965)
  [Maps] Organize layers into subfolders (#65513)
  skip flaky suite (#59849)
  Cleanup prefill and edit flow. (#66105)
  Fix major severity service map ring colors (#66124)
  [DOCS] Improves formatting in action types (#65932)
  [DOCS] APM Agent config: Setting values must be string (#65875)
  Change default cert age limit value. (#65918)
  [DOCS] Removed saved object options (#66072)
  [SIEM] [Cases] Case API tests (#65777)
  Add example of of local plugin installation (#65986)
  skip flaky suite (#65741)
  ...
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants