Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldowns][chore] Remove some any's from components. Remove PlaceContext from components #65854

Merged
merged 2 commits into from
May 12, 2020
Merged

[Drilldowns][chore] Remove some any's from components. Remove PlaceContext from components #65854

merged 2 commits into from
May 12, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented May 8, 2020 •
edited
Loading

Summary

Part of #42845

  • this removes some of not needed any from components
  • also removes PlaceContext. We removed it from service layer, but didn't from components (remove for now)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant added chore v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.9.0 labels May 8, 2020
@Dosant Dosant requested a review from a team May 8, 2020 14:01
@Dosant Dosant requested a review from a team as a code owner May 8, 2020 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Dosant
Dosant commented May 8, 2020
View reviewed changes
...ugins/drilldowns/public/components/flyout_drilldown_wizard/flyout_drilldown_wizard.story.tsx
@@ -35,7 +43,10 @@ storiesOf('components/FlyoutDrilldownWizard', module)
<EuiFlyout onClose={() => {}}>
<FlyoutDrilldownWizard
onClose={() => {}}
drilldownActionFactories={[urlFactory, dashboardFactory]}
drilldownActionFactories={[
urlFactory as ActionFactory,
Copy link
Contributor Author

@Dosant Dosant May 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in other places in this test have to downcast now because of how array types compatibility work

@Dosant Dosant requested review from stacey-gammon and streamich May 8, 2020 14:04
@flash1293
Copy link
Contributor

It seems like the new “sample data dashboard” functional test failed once on this Pr as well. I have the same problem on my cutover Pr - I tried to stabilize it over there and it seems like it’s helping - if it becomes a problem we can also merge this sooner than the cutover Pr itself.

stacey-gammon
stacey-gammon approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this Anton!

I started digging into the casting issue. Unfortunately I can't come up with any good work around, so, lgtm.

Code review only.

@Dosant
Copy link
Contributor Author

Dosant commented May 11, 2020

@elasticmachine merge upstream

@Dosant Dosant mentioned this pull request May 11, 2020
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant requested a review from ThomThomson May 11, 2020 08:14
ThomThomson
ThomThomson approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on chrome by creating and using dashboard drilldowns. Everything LGTM.

QQ: Isn't the current dashboard supposed to be hidden in the options for drilldowns? It doesn't break anything by being there, but it's maybe a small QOL thing. If I'm not mistaken, this is the responsibility of PlaceContext, and it should be restored after PlaceContext is re-introduced. Is that the case?

Screen Shot 2020-05-11 at 1 52 15 PM

@stacey-gammon
Copy link
Contributor

stacey-gammon commented May 11, 2020 •
edited
Loading

QQ: Isn't the current dashboard supposed to be hidden in the options for drilldowns?

There was an iteration that did that, but the code was removed bc it relied on dashboardEmbeddable.input.id being the saved object id, and that is not necessarily the case. Ideally, we'd have a dashboard by reference embeddable and use dashboardEmbeddableRef.input.savedObjectId.

@Dosant Dosant merged commit 0f5c1ed into elastic:master May 12, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request May 12, 2020
@Dosant @elasticmachine
[Drilldowns][chore] Remove some any's from components. Remove `PlaceC…
530c961 
…ontext` from components (elastic#65854)

Co-authored-by: Elastic Machine <[email protected]>
@Dosant Dosant mentioned this pull request May 12, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 12, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-components
073a924 
* master: (46 commits)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854)
  [functional/services] import By/until from module (elastic#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676)
  Inspect action shows on dashboard for every chart (elastic#65998)
  Fix heigt calc in calc issue for ie11 (elastic#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028)
  [SIEM] [Security] unified code structure phase 0 (elastic#65965)
  [Maps] Organize layers into subfolders (elastic#65513)
  skip flaky suite (elastic#59849)
  Cleanup prefill and edit flow. (elastic#66105)
  Fix major severity service map ring colors (elastic#66124)
  [DOCS] Improves formatting in action types (elastic#65932)
  [DOCS] APM Agent config: Setting values must be string (elastic#65875)
  Change default cert age limit value. (elastic#65918)
  [DOCS] Removed saved object options (elastic#66072)
  [SIEM] [Cases] Case API tests (elastic#65777)
  Add example of of local plugin installation (elastic#65986)
  skip flaky suite (elastic#65741)
  [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583)
  [Reporting/Test] Add Functional test for download CSV (elastic#65401)
  ...
jloleysens added a commit that referenced this pull request May 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
6316956 
…ine-editor

* 'master' of github.com:elastic/kibana: (37 commits)
  [APM] Correct relative paths in scripts (#66159)
  [Uptime] Enable deselection of stale filters (#65523)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854)
  [functional/services] import By/until from module (#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (#65676)
  Inspect action shows on dashboard for every chart (#65998)
  Fix heigt calc in calc issue for ie11 (#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (#66028)
  [SIEM] [Security] unified code structure phase 0 (#65965)
  [Maps] Organize layers into subfolders (#65513)
  skip flaky suite (#59849)
  Cleanup prefill and edit flow. (#66105)
  Fix major severity service map ring colors (#66124)
  [DOCS] Improves formatting in action types (#65932)
  [DOCS] APM Agent config: Setting values must be string (#65875)
  Change default cert age limit value. (#65918)
  [DOCS] Removed saved object options (#66072)
  [SIEM] [Cases] Case API tests (#65777)
  Add example of of local plugin installation (#65986)
  skip flaky suite (#65741)
  ...
Dosant added a commit that referenced this pull request May 12, 2020
@Dosant @elasticmachine
[Drilldowns][chore] Remove some any's from components. Remove `PlaceC…
425095a 
…ontext` from components (#65854) (#66167)

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
chore Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Dosant @elasticmachine @flash1293 @kibanamachine @stacey-gammon @streamich @ThomThomson