Fixing kbn append nav controls #6502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panda01
commented
Mar 10, 2016
panda01
commented
- Modifies the Config object
- Changes the kibana logo to the latest
- Fixes spacing issue with timepicker showing a bottom border
- Moves append nav controls to the sidebar on the left
- Removes the timepicker and loading indicator from the kbn append nav controls
| @@ -52,7 +52,8 @@ | |||
| ng-click="configTemplate.toggle('options');"> | |||
| <span>Options</span> | |||
| </button> | |||
| <div class="chrome-actions"kbn-chrome-append-nav-controls></div> | |||
| <kbn-loading-indicator></kbn-loading-indicator> | |||
There was a problem hiding this comment.
As discussed yesterday, move this loading indicator out to the chrome.
There was a problem hiding this comment.
Was discussed this can be push until after launch.
|
@panda01 whats the status here? |
|
@rashidkpc made some changes, if you fetch you'll see a new logo. Next is tests. |
Closed
…picker directives
|
jenkins, test it |
Signed-off-by: Tyler Smalley <[email protected]>
|
@panda01 this is passing now. |
|
@panda01 I'm removing the review tag from this, re-it when you're ready for someone to look at it again. |
panda01
force-pushed
the
feature/design
branch
2 times, most recently
from
116d8e8 to
ec21570
Compare
…cope, and be a bit more transparent, also some code cleanup
| transclude: true, | ||
| template: ` | ||
| <div class="config" ng-show="kbnTopNavbar.currTemplate"> | ||
| <div id="template_wrapper" class="container-fluid"></div> |
There was a problem hiding this comment.
Ideally this would use ng-bind-html, but that requires $sanitize and such
This was referenced Mar 24, 2016
|
Continued in the above PRs. |
cee-chen
pushed a commit
that referenced
this pull request
Feb 9, 2023
## Summary `[email protected]` ⏩ `[email protected]` ___ ## [`74.1.0`](https://github.com/elastic/eui/releases/tag/v74.1.0) - Added new `EuiSkeletonText`, `EuiSkeletonTitle`, `EuiSkeletonCircle`, and `EuiSkeletonRectangle` components ([#6502](elastic/eui#6502)) - Updated `EuiSuperSelect` screen reader instructions to be more specific ([#6549](elastic/eui#6549)) - Added `error` and updated `alert` glyphs to `EuiIcon` ([#6550](elastic/eui#6550)) - All `EuiSkeleton` components now accept an `isLoading` flag and `children`, which automatically handles conditionally rendering loading skeletons vs. loaded content (`children`) ([#6562](elastic/eui#6562)) - All `EuiSkeleton` components now accept a `contentAriaLabel` prop, which more meaningfully describes the loaded content to screen readers ([#6562](elastic/eui#6562)) - Updated `EuiPopover` screen reader instructions for mobile and click behaviors ([#6567](elastic/eui#6567)) **Bug fixes** - Fixed `EuiCard` to ensure `onClick` method only runs once when `title` contains a React node ([#6551](elastic/eui#6551)) **Deprecations** - Deprecated `EuiLoadingContent` - use `EuiSkeletonText` instead ([#6557](elastic/eui#6557)) --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.