Kibana 5 design #6239
Kibana 5 design #6239
Conversation
…ebar function as expected with overlap
[visualize] Change first chart color
Add more color variables
[font] Bump base size to 14px
…red, added placedholders for users and settings, fixed the sizing on the logo
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
| ng-click="configTemplate.toggle('options');"> | ||
| <span>Options</span> | ||
| </button> | ||
| <div class="chrome-actions"kbn-chrome-append-nav-controls></div> |
There was a problem hiding this comment.
The spinner needs to be moved out of kbn-chrome-append-nav-controls and into the overall chrome otherwise it will be missing in any application that doesn't use kbn-chrome-append-nav-controls.
|
jenkins, test it |
|
@tylersmalley can you take a look at the last couple failing tests here? |
|
Looking into them now @rashidkpc |
Signed-off-by: Tyler Smalley <[email protected]>
[K5] Resolves test failures for feature/design branch
|
🎉 |
|
We said we were going to merge this when it goes green and work on any remaining bugs in master, so I'm going to merge it. Feel free to revert (or prod me to) if that's not the case. |
|
Actually, might as well give this test run ago again to help ensure there aren't timing issues or something. |
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
|
Yep, tests are definitely looking good. |
|
I have a pull I want to put into this first. Actually 2
|
|
Alright. I was literally hovering my mouse over the merge button when your comment came through. |
|
Lol, I searched my feelings, I know this to be true. Almost man
|
This pull is basically good to go, though there is some stuff that needs to change that is being tracked here: #6387