-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kibana 5 design #6239
Kibana 5 design #6239
Changes from 250 commits
8f127ea
5e49edd
3f1c980
70a7077
bbeb13b
9d4d38d
8b21ed0
775812a
eef94c7
5de1094
b5ca051
bc4dce1
e300508
858c02a
540a8af
729dbd7
b41fbee
e16d9a8
3c125d2
1345c6a
bf82967
f7c98cc
55936bc
e53224c
c9b8d8c
31c51ad
024835a
9abdc62
2f65759
03e1082
7f6fc7e
71cb775
722494a
d4e0afc
53190af
3733e73
74d5f24
9ee9715
08cbdec
3a281ee
6fad32f
fec7f67
f2c85d9
e63900a
a75df51
0a1b516
3abd125
e106eb9
d831293
f9d9beb
5af3696
31a2f5c
c2b786e
3100a2f
e7c98c0
d920095
fafd8cd
8f9d8b3
4dbba2f
b2e0ff1
5b1576f
16300d6
6afcb8c
1832f2f
ace35c3
680e0bf
e712612
e96cb37
4304d58
f4c3b9b
ba5b57e
70f5f99
74e67f0
40a21b9
da2725d
b28d572
ae8049a
400a31c
180aacd
d5c0829
af5f0b6
1e5af5b
48e8126
fc4cf84
552bc63
f57ed8d
81f4d8d
f072adf
bf5d73e
d7d730a
4eb4424
fe624a8
028610a
7e44810
04bca77
22fd469
a3e7ec4
2e656a3
bee278a
dbc9076
5b2d3ee
0f5cc90
a70c9e5
68d95b5
a6d904e
edece70
981ac4e
e2ee1d9
b228285
81fb4b5
0a5a7f0
9766285
c88e10a
06f8f15
e3530ad
cdd0ac2
e78735f
9e08fb1
c625187
18ce61b
8054a85
09cb3a6
8678d30
b1754a2
849897d
911ad8e
9c8c7f4
bc10322
958dabf
f68055e
ff363d8
d091d9f
fa5cd54
26596e8
85dce5c
680bc40
07bf084
bcb4a0f
ca9ef6a
5259b63
4f3b315
eb4a3cf
6f8f7bc
797c059
1ff765b
b2f09de
ea0fc97
e78d434
910027a
c3209d6
4622a4c
ee2b0b0
a214dcd
9787989
1ea8f64
b184e08
27138d1
040969c
30d8445
7bc5573
2ce4dfb
6252706
2d647af
34b8296
e1148df
14dd339
dbfdde8
c575789
2ba854b
0bb80ca
84c3ae6
66b6277
c1c2f0b
064b043
b3675f0
735a197
629365f
c9e0c5f
de0697c
6085777
daf8466
ef82d3a
2fbe482
4f365b5
59169b8
55d79b5
804c7a9
d38346c
73c0f9e
9382b34
90990f0
f41c3a8
5790cb3
66db302
0dc74e1
30dfe77
aa36e68
a882445
431ba87
b5417e9
2c3eccf
52cf10a
9502ade
a2b92ac
f55c978
4119554
c6432bc
99f4812
7af5419
ba61485
1935400
7dda370
344a444
cabf785
ad3375e
6ff4e0d
aee024b
18f9f78
c7a412e
6acffc6
aecd79a
bfe4d89
3bfc088
f4ee8e3
0049a48
3c0d12a
6edcc11
1c713f5
360acd9
c6acd78
ab21884
63cf30c
a25f8f9
0e39338
172f5c3
c42d9c2
29fb459
fb68898
ccdfb20
1ddc94d
a27de44
67ca0cc
aae8583
cf838ff
ba558c2
4f60573
8522b2f
32cad00
953e154
42b87c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
.aws-config.json | ||
.ackrc | ||
.DS_Store | ||
.node_binaries | ||
node_modules | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,9 @@ app.directive('dashboardApp', function (Notifier, courier, AppState, timefilter, | |
load: require('plugins/kibana/dashboard/partials/load_dashboard.html'), | ||
share: require('plugins/kibana/dashboard/partials/share.html'), | ||
pickVis: require('plugins/kibana/dashboard/partials/pick_visualization.html'), | ||
options: require('plugins/kibana/dashboard/partials/options.html') | ||
options: require('plugins/kibana/dashboard/partials/options.html'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can all of these be moved to import statements? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are a few require statements throughout the code bse as you can see above, I say we open an issue to get to all of them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
filter: require('ui/chrome/config/filter.html'), | ||
interval: require('ui/chrome/config/interval.html') | ||
}); | ||
|
||
$scope.refresh = _.bindKey(courier, 'fetch'); | ||
|
@@ -239,7 +241,8 @@ app.directive('dashboardApp', function (Notifier, courier, AppState, timefilter, | |
ui: $state.options, | ||
save: $scope.save, | ||
addVis: $scope.addVis, | ||
addSearch: $scope.addSearch | ||
addSearch: $scope.addSearch, | ||
timefilter: $scope.timefilter | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be needed, the timepicker should just interact with the timefilter service when used in the context of the chrome. Of course the time picker should remain reusable since its only real purpose is it set properties of an object. |
||
}; | ||
|
||
init(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spinner needs to be moved out of
kbn-chrome-append-nav-controls
and into the overall chrome otherwise it will be missing in any application that doesn't usekbn-chrome-append-nav-controls
.