Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana 5 design #6239

Merged
merged 264 commits into from
Mar 22, 2016
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
264 commits
Select commit Hold shift + click to select a range
8f127ea
Fix conflict between gray and green less variables
jbudz Feb 1, 2016
5e49edd
[visualize] Change base chart color
jbudz Feb 1, 2016
3f1c980
init changes to Visualize Page redesign
stormpython Feb 2, 2016
70a7077
[font] Bump base size to 14px
jbudz Feb 2, 2016
bbeb13b
Merge branch 'feature/design' of github.com:elastic/kibana into featu…
stormpython Feb 2, 2016
9d4d38d
Merge remote-tracking branch 'upstream/master' into feature/5.0
panda01 Feb 2, 2016
8b21ed0
[Css] Changing the css to accomodate the new logo dimensions
panda01 Feb 2, 2016
775812a
Merge branch 'master' into implement/exportLinks
spalger Feb 2, 2016
eef94c7
[appSwitcher] es6-ify
spalger Feb 2, 2016
5de1094
[chrome/api/apps] use path getter rather than multiple checks
spalger Feb 2, 2016
b5ca051
[ui/UiApp] dress like a cool kid
spalger Feb 2, 2016
bc4dce1
[ui/uiNav*] es6-ify
spalger Feb 2, 2016
e300508
[Chrome] Moved the notifications to the proper location, made the sid…
panda01 Feb 2, 2016
858c02a
Make color names more specific
jbudz Feb 2, 2016
540a8af
[visualize test] Update fill color
jbudz Feb 2, 2016
729dbd7
adding more inline styles to break out later
stormpython Feb 2, 2016
b41fbee
more preliminary changes in style for the paginate element
stormpython Feb 3, 2016
e16d9a8
[Logo] Change the color of the logo
panda01 Feb 4, 2016
3c125d2
cleaning up, moving inline style to less files
stormpython Feb 4, 2016
1345c6a
Merge pull request #6062 from jbudz/design/base_chart_color
jbudz Feb 4, 2016
bf82967
Merge pull request #6050 from jbudz/design/colors
jbudz Feb 4, 2016
f7c98cc
Merge branch 'feature/design' into feature/5.0
panda01 Feb 4, 2016
55936bc
Merge pull request #6067 from jbudz/design/font_size
jbudz Feb 4, 2016
e53224c
[Chrome] Made it so the right panel slides over instead of being cove…
panda01 Feb 4, 2016
c9b8d8c
updating css changes to use flexbox instead of bootstrap grid
stormpython Feb 4, 2016
31c51ad
Merge branch 'feature/design' of github.com:elastic/kibana into featu…
stormpython Feb 4, 2016
024835a
initial changes to step 2 process, styling and html changes to step 1
stormpython Feb 5, 2016
9abdc62
Merge remote-tracking branch 'upstream/feature/design' into feature/5.0
panda01 Feb 5, 2016
2f65759
Change new, open, save, share search icons to words
jbudz Jan 29, 2016
03e1082
[discover] Move options above search
jbudz Jan 29, 2016
7f6fc7e
[discover] Change navbar colors, remove borders
jbudz Feb 1, 2016
71cb775
[discover] Pad navbars
jbudz Feb 1, 2016
722494a
[nav] Remove box shadow
jbudz Feb 2, 2016
d4e0afc
[discover] Update variable names
jbudz Feb 2, 2016
53190af
[discover] Update sidebar colors
jbudz Feb 2, 2016
3733e73
[discover] Move navbar padding changes, fixes firefox crashing
jbudz Feb 3, 2016
74d5f24
[Chrome] Made the kibana logo the fallback if there is no logo, hide …
panda01 Feb 8, 2016
9ee9715
Primary button is blue, sidebar nav is lighter gray
jbudz Feb 8, 2016
08cbdec
[discover] Add active style when toggling sidebar field
jbudz Feb 8, 2016
3a281ee
Merge pull request #6047 from panda01/feature/5.0
panda01 Feb 8, 2016
6fad32f
[discover] Add index pattern active color
jbudz Feb 8, 2016
fec7f67
[collapser] Background color is white
jbudz Feb 8, 2016
f2c85d9
Merge branch 'design' into implement/exportLinks
simianhacker Feb 8, 2016
e63900a
troubleshooting styling for step 1 and step 2 visualize pages
stormpython Feb 8, 2016
a75df51
Change svg to be inkscape compatible
Feb 8, 2016
0a1b516
Add padding around logo
Feb 8, 2016
3abd125
Add drop shadow, hover effect, center icons vertically
Feb 8, 2016
e106eb9
Move logo text up. Reduce width of sidebar to 160px
Feb 8, 2016
d831293
Adding svgs and CSS for nav
simianhacker Feb 9, 2016
f9d9beb
Fix merge
Feb 9, 2016
5af3696
adding inline styles to line up with spec
stormpython Feb 9, 2016
31a2f5c
[Dashboard] Started the redesign for the 5.0. Made the background whi…
panda01 Feb 9, 2016
c2b786e
[bootstrap] Change well color
jbudz Feb 9, 2016
3100a2f
Add flex container inside app-wrapper, attach shadow to that
Feb 9, 2016
e7c98c0
Fix icons in firefox
Feb 9, 2016
d920095
adding background color to pagination numbers
stormpython Feb 9, 2016
fafd8cd
Merge pull request #6086 from jbudz/design/discover
panda01 Feb 9, 2016
8f9d8b3
css changes to the legend
stormpython Feb 9, 2016
4dbba2f
[Icons] vertically aligned the icons
panda01 Feb 9, 2016
b2e0ff1
Merge remote-tracking branch 'upstream/feature/design' into fix/nav-d…
panda01 Feb 9, 2016
5b1576f
[Tests] Updated the tests with thte proper selector
panda01 Feb 9, 2016
16300d6
Merge remote-tracking branch 'upstream/master' into feature/design-me…
tsullivan Feb 10, 2016
6afcb8c
[AppSwitcher] expanded the less so it's more understandable
panda01 Feb 10, 2016
1832f2f
adding text color to select text
stormpython Feb 10, 2016
ace35c3
removing inline styles
stormpython Feb 10, 2016
680e0bf
removing inline style, adding color to font awesome icon
stormpython Feb 10, 2016
e712612
fixing broken tests
stormpython Feb 10, 2016
e96cb37
Merge pull request #6182 from tsullivan/feature/design-merge-master3
jbudz Feb 10, 2016
4304d58
[dashboard] Move nav buttons to icons
jbudz Feb 5, 2016
f4c3b9b
[visualize] Move nav buttons to icons
jbudz Feb 5, 2016
ba5b57e
[nav] Increase padding below search
jbudz Feb 8, 2016
70f5f99
[tests] Remove ng-scope from visualize action selector
jbudz Feb 9, 2016
74e67f0
[visualize] Remove tab container top border
jbudz Feb 10, 2016
40a21b9
Merge pull request #6162 from jbudz/design/nav
jbudz Feb 10, 2016
da2725d
Merge remote-tracking branch 'upstream/feature/design' into legend
stormpython Feb 10, 2016
b28d572
adding changes to tooltips
stormpython Feb 10, 2016
ae8049a
removing the commented sections
stormpython Feb 10, 2016
400a31c
removing legend from Discover page, also removing functional tests fo…
stormpython Feb 10, 2016
180aacd
Merge remote-tracking branch 'upstream/feature/design' into fix/nav-d…
panda01 Feb 10, 2016
d5c0829
removing legend tests
stormpython Feb 10, 2016
af5f0b6
Merge pull request #6170 from panda01/fix/nav-details
panda01 Feb 10, 2016
1e5af5b
[Chore] Some code cleanup
panda01 Feb 10, 2016
48e8126
Merge remote-tracking branch 'upstream/feature/design' into visualize
stormpython Feb 11, 2016
fc4cf84
removing the word , making open/close icon inline with the legend list
stormpython Feb 11, 2016
552bc63
reducing the size of the legend icon
stormpython Feb 11, 2016
f57ed8d
Merge pull request #6169 from stormpython/legend
panda01 Feb 11, 2016
81f4d8d
reducing line height
stormpython Feb 11, 2016
f072adf
adding media query for step 1, adding flex to saved object finder for…
stormpython Feb 11, 2016
bf5d73e
minor changes
stormpython Feb 11, 2016
d7d730a
[Chore] Removing mistakenly commited code
panda01 Feb 11, 2016
4eb4424
[Visualize] Changed visuzlize over to the 5.0 design
panda01 Feb 11, 2016
fe624a8
css changes to the legend
stormpython Feb 9, 2016
028610a
removing inline style, adding color to font awesome icon
stormpython Feb 10, 2016
7e44810
fixing broken tests
stormpython Feb 10, 2016
04bca77
removing legend from Discover page, also removing functional tests fo…
stormpython Feb 10, 2016
22fd469
removing legend tests
stormpython Feb 10, 2016
a3e7ec4
removing the word , making open/close icon inline with the legend list
stormpython Feb 11, 2016
2e656a3
reducing the size of the legend icon
stormpython Feb 11, 2016
bee278a
Merge remote-tracking branch 'upstream/feature/design' into feature/v…
panda01 Feb 11, 2016
dbc9076
cleaning up css, variabilizing colors
stormpython Feb 11, 2016
5b2d3ee
small tweaks to clean up css
stormpython Feb 11, 2016
0f5cc90
Merge pull request #6197 from panda01/fix/excess-log
panda01 Feb 11, 2016
a70c9e5
adding .empty file
stormpython Feb 11, 2016
68d95b5
replacing #ffffff with @white variable
stormpython Feb 11, 2016
a6d904e
Inject chrome instead of requiring
Feb 11, 2016
edece70
Use kbn-src in status page
Feb 11, 2016
981ac4e
Add slash
Feb 11, 2016
e2ee1d9
Setting the sidenav delay to .25s
simianhacker Feb 11, 2016
b228285
Merge pull request #6195 from panda01/feature/visualize
panda01 Feb 11, 2016
81fb4b5
Merge pull request #6188 from stormpython/design/tooltip
panda01 Feb 11, 2016
0a5a7f0
Merge pull request #6201 from simianhacker/design/delay-fix
simianhacker Feb 11, 2016
9766285
Change config close buttons
Feb 11, 2016
c88e10a
Change collapsible sidebar to circle chevron
Feb 11, 2016
06f8f15
Use the right shade of glorious kibana gray. ALL GLORY TO GRAY
Feb 11, 2016
e3530ad
Merge pull request #6200 from rashidkpc/fix/status_page_buttons
panda01 Feb 11, 2016
cdd0ac2
Merge branch 'master' into design/master
jbudz Feb 11, 2016
e78735f
[SearchBar] Fixed the height on the search bar
panda01 Feb 11, 2016
9e08fb1
Merge branch 'master' of github.com:elastic/kibana into feature/design
simianhacker Feb 11, 2016
c625187
Merge pull request #6204 from rashidkpc/design/close-button
Feb 11, 2016
18ce61b
Merge pull request #6205 from rashidkpc/fix/collapable-sidebar-icon
Feb 11, 2016
8054a85
Merge pull request #6206 from jbudz/design/master
Feb 11, 2016
09cb3a6
[timepicker] Move next to page actions
jbudz Feb 9, 2016
8678d30
[timepicker] Add context to each page
jbudz Feb 10, 2016
b1754a2
[nav] Active pills are yellow
jbudz Feb 10, 2016
849897d
[nav] Remove focused outline
jbudz Feb 11, 2016
911ad8e
[timepicker] Use a single config
jbudz Feb 11, 2016
9c8c7f4
[timepicker] Update test selector
jbudz Feb 11, 2016
bc10322
[timepicker] Set scope properly, update spinner selector on tests, wa…
jbudz Feb 11, 2016
958dabf
Merge pull request #6198 from jbudz/design/timepicker
Feb 11, 2016
f68055e
[SearchBar] Positioned the close button, updated the style on the pag…
panda01 Feb 11, 2016
ff363d8
Adding colors and fixing spacing
simianhacker Feb 11, 2016
d091d9f
[visualize] Update linked visualization color
jbudz Feb 11, 2016
fa5cd54
Merge branch 'master' into feature/design
Feb 11, 2016
26596e8
Fixing spacing a bit more and using the speced colors
simianhacker Feb 11, 2016
85dce5c
Merge branch 'feature/design' of github.com:elastic/kibana into featu…
simianhacker Feb 11, 2016
680bc40
Merge branch 'feature/design' into icon-fixes
simianhacker Feb 11, 2016
07bf084
Merge branch 'feature/design' into pr/6190
Feb 11, 2016
bcb4a0f
Merge remote-tracking branch 'upstream/feature/design' into fix/heade…
panda01 Feb 11, 2016
ca9ef6a
Good enough
simianhacker Feb 11, 2016
5259b63
[Navbar] Made the navbar spacing universal, also properly sized the l…
panda01 Feb 11, 2016
4f3b315
Merge pull request #6212 from simianhacker/icon-fixes
simianhacker Feb 11, 2016
eb4a3cf
Merge pull request #6207 from panda01/fix/header-details
simianhacker Feb 11, 2016
6f8f7bc
Tighten up spacing, add pink border on hover
Feb 11, 2016
797c059
Merge remote-tracking branch 'upstream/feature/design' into pr/6190
Feb 11, 2016
1ff765b
Use gray instead of pink
Feb 11, 2016
b2f09de
Merge remote-tracking branch 'upstream/master' into feature/design
Feb 11, 2016
ea0fc97
Merge pull request #6211 from panda01/fix/dearch-details
Feb 11, 2016
e78d434
Make sidebar buttons and index patterns the same height
Feb 11, 2016
910027a
removing dropdown menu, splitting screen on step_2 as in step_1.html,…
stormpython Feb 11, 2016
c3209d6
Merge pull request #6215 from rashidkpc/tweak/buttons_index_pattern_s…
Feb 11, 2016
4622a4c
Change cursor to pointer when hovering panel-header, make panel heade…
Feb 12, 2016
ee2b0b0
renaming table header, correcting link function
stormpython Feb 12, 2016
a214dcd
Changes for the new spinner
simianhacker Feb 12, 2016
9787989
Removing the spinner content
simianhacker Feb 12, 2016
1ea8f64
cleaning up
stormpython Feb 12, 2016
b184e08
removing unused functions that will surely break tests
stormpython Feb 12, 2016
27138d1
Align filter bar with sidebar button heights
Feb 12, 2016
040969c
fixing issue with left column not expanding to match right column in …
stormpython Feb 12, 2016
30d8445
Merge pull request #6217 from rashidkpc/tweak/filterbar-align
Feb 12, 2016
7bc5573
fixing issue with right column not matching left column on step-1
stormpython Feb 12, 2016
2ce4dfb
Merge pull request #6214 from rashidkpc/feature/dashboard-restyle
simianhacker Feb 12, 2016
6252706
Remove border radius on timepicker button
Feb 12, 2016
2d647af
Merge pull request #6216 from simianhacker/new-spinner
Feb 12, 2016
34b8296
Merge pull request #6213 from jbudz/design/vis-linked
Feb 12, 2016
e1148df
Remove opacity change from discover, fix spinner flicker
Feb 12, 2016
14dd339
Merge pull request #6225 from rashidkpc/tweak/css-delays
spalger Feb 12, 2016
dbfdde8
Merge branch 'master' of github.com:elastic/kibana into feature/design
tsullivan Feb 12, 2016
c575789
adding capitalize filter to deal with title words, tweaking padding, …
stormpython Feb 12, 2016
2ba854b
replacing noun with nouns as the placeholder for text input
stormpython Feb 12, 2016
0bb80ca
[nav] Only show interval when timepicker is active
jbudz Feb 12, 2016
84c3ae6
Revert "Close button positioning"
Feb 12, 2016
66b6277
Merge pull request #6240 from elastic/revert-6211-fix/dearch-details
Feb 12, 2016
c1c2f0b
Change version to include -reskin for snapshots
Feb 12, 2016
064b043
Run snapshots
Feb 12, 2016
b3675f0
Merge pull request #6233 from tsullivan/master-merge-feature/design3
lukasolson Feb 12, 2016
735a197
finishing tests for capitalize filter, adding ability to add non-capi…
stormpython Feb 13, 2016
629365f
Tighten up spacing, move drag handle, move spy toggle
Feb 13, 2016
c9e0c5f
Merge branch 'master' into tweak/smallspy
Feb 13, 2016
de0697c
Import all of lodash
Feb 16, 2016
6085777
Don't paint spinner when its not doing anything
Feb 16, 2016
daf8466
Move dashboard title
Feb 16, 2016
ef82d3a
Merge remote-tracking branch 'upstream/feature/design' into feature/d…
Feb 16, 2016
2fbe482
Use new style for visualization title in editor
Feb 16, 2016
4f365b5
[Chrome] Changed the chrome Tabs to the new design. Removed the tabs …
panda01 Feb 22, 2016
59169b8
Merge pull request #6301 from panda01/feature/chrome-tabs
panda01 Feb 25, 2016
55d79b5
Merge pull request #6238 from jbudz/design/time-interval
jbudz Feb 26, 2016
804c7a9
Merge pull request #6263 from rashidkpc/fix/spinner-resources
Feb 29, 2016
d38346c
Merge branch 'feature/design' into visualize
stormpython Mar 2, 2016
73c0f9e
working on sorting
stormpython Mar 3, 2016
9382b34
adding sortable hits for saved object finder
stormpython Mar 3, 2016
90990f0
small refactor
stormpython Mar 3, 2016
f41c3a8
refactoring
stormpython Mar 3, 2016
5790cb3
adding comments
stormpython Mar 3, 2016
66db302
[CSS] Cleaned up some CSS and normalized styles
panda01 Mar 4, 2016
0dc74e1
Merge pull request #6435 from panda01/feature/design
panda01 Mar 7, 2016
30dfe77
Update nav.js
spalger Mar 7, 2016
aa36e68
Change cursor to move button
Mar 8, 2016
a882445
Merge branch 'feature/design' of github.com:elastic/kibana into tweak…
Mar 8, 2016
431ba87
Merge pull request #6247 from rashidkpc/tweak/smallspy
Mar 8, 2016
b5417e9
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython Mar 8, 2016
2c3eccf
removing spaces
stormpython Mar 8, 2016
52cf10a
[Chrome] Fixed getActiveTabId
panda01 Mar 8, 2016
9502ade
Merge remote-tracking branch 'origin/master' into feature/design
Mar 9, 2016
a2b92ac
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython Mar 9, 2016
f55c978
Merge remote-tracking branch 'upstream/feature/design' into implement…
panda01 Mar 9, 2016
4119554
[Chrome] Moved some things around to keep the chrome consistent
panda01 Mar 9, 2016
c6432bc
refactoring less
stormpython Mar 10, 2016
99f4812
refactoring less files
stormpython Mar 10, 2016
7af5419
refactoring less files
stormpython Mar 10, 2016
ba61485
refactoring less and html files
stormpython Mar 10, 2016
1935400
Merge branch 'master' of github.com:elastic/kibana into feature/design
spalger Mar 10, 2016
7dda370
Merge branch 'renameAllFiles' into feature/design
spalger Mar 10, 2016
344a444
using text-transform in favor or custom capitalize filter
stormpython Mar 10, 2016
cabf785
reverting a small change
stormpython Mar 10, 2016
ad3375e
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython Mar 10, 2016
6ff4e0d
changes addressing reviewer comments
stormpython Mar 10, 2016
aee024b
addressing reviewer comments
stormpython Mar 11, 2016
18f9f78
add kbn-href
stormpython Mar 11, 2016
c7a412e
fixing padding
stormpython Mar 11, 2016
6acffc6
aligning kibana logo with navbar
stormpython Mar 14, 2016
aecd79a
[Chrome] Added a breadcrumbs method
panda01 Mar 14, 2016
bfe4d89
[Tests] Trying to test the angular api
panda01 Mar 14, 2016
3bfc088
lining up visualize sidebar with side nav bar as well as fixing hover…
stormpython Mar 14, 2016
f4ee8e3
fixing issue with url query string
stormpython Mar 15, 2016
0049a48
Merge pull request #6156 from stormpython/visualize
Mar 15, 2016
3c0d12a
Merge branch 'master' of github.com:elastic/kibana into feature/desig…
spalger Mar 16, 2016
6edcc11
removing extra padding
stormpython Mar 16, 2016
1c713f5
Merge branch 'feature/design' into settings/searchbar
stormpython Mar 16, 2016
360acd9
adding padding back
stormpython Mar 16, 2016
c6acd78
Merge pull request #6505 from spalger/feature/designMergeSnakeCase
spalger Mar 16, 2016
ab21884
Merge remote-tracking branch 'panda01/implement/activeAppId' into set…
stormpython Mar 16, 2016
63cf30c
moving padding-top style under .nav, merging in Khalah's breadcrumb b…
stormpython Mar 16, 2016
a25f8f9
Resolves functional tests for K5 redesign
Mar 10, 2016
0e39338
adding breadcrumbs
stormpython Mar 16, 2016
172f5c3
Merge pull request #6536 from tylersmalley/feature/design-tests
spalger Mar 16, 2016
c42d9c2
Merge branch 'feature/design' into settings/searchbar
stormpython Mar 17, 2016
29fb459
addressing reviewer comments
stormpython Mar 17, 2016
fb68898
removing debugger statement
stormpython Mar 17, 2016
ccdfb20
troubleshooting file not found error
stormpython Mar 17, 2016
1ddc94d
removing makeUrl function
stormpython Mar 17, 2016
a27de44
removing makeUrl from html, updating css
stormpython Mar 17, 2016
67ca0cc
Merge pull request #6527 from stormpython/settings/searchbar
panda01 Mar 17, 2016
aae8583
Merge branch 'master' into feature/design
stormpython Mar 18, 2016
cf838ff
Merge branch 'master' into feature/design
Mar 21, 2016
ba558c2
Remove unused styles
Mar 21, 2016
4f60573
Normalize timepicker toggle into same style as other buttons
Mar 21, 2016
8522b2f
Remove right padding
Mar 21, 2016
32cad00
Merge remote-tracking branch 'upstream/master' into feature/design
Mar 22, 2016
953e154
Re-adds test page helpers removed by merge
Mar 22, 2016
42b87c7
Merge pull request #6593 from tylersmalley/feature/design-test-2
spalger Mar 22, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.aws-config.json
.ackrc
.DS_Store
.node_binaries
node_modules
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dashboarding"
],
"private": false,
"version": "5.0.0-snapshot",
"version": "5.0.0-reskin-snapshot",
"build": {
"number": 8467,
"sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9"
Expand Down
3 changes: 2 additions & 1 deletion src/optimize/base_optimizer.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class BaseOptimizer {

getConfig() {
let mapQ = this.sourceMaps ? '?sourceMap' : '';
let mapQPre = mapQ ? mapQ + '&' : '?';

return {
context: fromRoot('.'),
Expand Down Expand Up @@ -101,7 +102,7 @@ class BaseOptimizer {
test: /\.less$/,
loader: ExtractTextPlugin.extract(
'style',
`css${mapQ}!autoprefixer${mapQ ? mapQ + '&' : '?'}{ "browsers": ["last 2 versions","> 5%"] }!less${mapQ}`
`css${mapQ}!autoprefixer${mapQPre}{ "browsers": ["last 2 versions","> 5%"] }!less${mapQPre}dumpLineNumbers=comments`
)
},
{ test: /\.css$/, loader: ExtractTextPlugin.extract('style', `css${mapQ}`) },
Expand Down
36 changes: 34 additions & 2 deletions src/plugins/kibana/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import search from './server/routes/api/search';

module.exports = function (kibana) {
return new kibana.Plugin({

id: 'kibana',
config: function (Joi) {
return Joi.object({
enabled: Joi.boolean().default(true),
Expand All @@ -14,7 +14,9 @@ module.exports = function (kibana) {

uiExports: {
app: {
id: 'kibana',
title: 'Kibana',
listed: false,
description: 'the kibana you know and love',
//icon: 'plugins/kibana/settings/sections/about/barcode.svg',
main: 'plugins/kibana/kibana',
Expand All @@ -33,9 +35,39 @@ module.exports = function (kibana) {
return {
kbnDefaultAppId: config.get('kibana.defaultAppId')
};
}
},
},

links: [
{
title: 'Discover',
order: -1003,
url: '/app/kibana#/discover',
description: 'interactively explore your data',
icon: 'plugins/kibana/assets/discover.svg',
},
{
title: 'Visualize',
order: -1002,
url: '/app/kibana#/visualize',
description: 'design data visualizations',
icon: 'plugins/kibana/assets/visualize.svg',
},
{
title: 'Dashboard',
order: -1001,
url: '/app/kibana#/dashboard',
description: 'compose visualizations for much win',
icon: 'plugins/kibana/assets/dashboard.svg',
},
{
title: 'Settings',
order: 1000,
url: '/app/kibana#/settings',
description: 'define index patterns, change config, and more',
icon: 'plugins/kibana/assets/settings.svg',
}
],
injectDefaultVars(server, options) {
return {
kbnIndex: options.index
Expand Down
4 changes: 4 additions & 0 deletions src/plugins/kibana/public/assets/dashboard.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/plugins/kibana/public/assets/discover.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/plugins/kibana/public/assets/logout.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions src/plugins/kibana/public/assets/search.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions src/plugins/kibana/public/assets/settings.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/plugins/kibana/public/assets/visualize.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
<div class="panel panel-default" ng-switch on="panel.type" ng-if="savedObj || error">
<div class="panel-heading">
<span class="panel-title" title="{{::savedObj.title}}">
<i
class="fa"
ng-class="savedObj.vis.type.icon"
aria-label="{{::savedObj.vis.type.title}} Icon"
title="{{::savedObj.vis.type.title}}">
</i>
{{::savedObj.title}}
</span>
<div class="btn-group">
<a aria-label="Edit" ng-show="chrome.getVisible() && editUrl" ng-href="{{::editUrl}}">
<i aria-hidden="true" class="fa fa-pencil"></i>
</a>
<a aria-label="Move" ng-show="chrome.getVisible()" class="panel-move">
<i aria-hidden="true" class="fa fa-arrows"></i>
</a>
<a aria-label="Remove" ng-show="chrome.getVisible()" ng-click="remove()">
<i aria-hidden="true" class="fa fa-times"></i>
</a>
Expand Down
5 changes: 2 additions & 3 deletions src/plugins/kibana/public/dashboard/directives/grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
// number of columns to render
const COLS = 12;
// number of pixed between each column/row
const SPACER = 10;
const SPACER = 0;
// pixels used by all of the spacers (gridster puts have a spacer on the ends)
const spacerSize = SPACER * COLS;

Expand All @@ -46,7 +46,7 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
stop: readGridsterChangeHandler
},
draggable: {
handle: '.panel-heading, .panel-title',
handle: '.panel-move, .fa-arrows',
stop: readGridsterChangeHandler
}
}).data('gridster');
Expand Down Expand Up @@ -232,4 +232,3 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
}
};
});

118 changes: 58 additions & 60 deletions src/plugins/kibana/public/dashboard/index.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,62 @@
<div dashboard-app class="app-container dashboard-container">
<navbar ng-show="chrome.getVisible()" name="dashboard">
<span class="name" ng-if="dash.id" ng-bind="::dash.title" tooltip="{{::dash.title}}" tooltip-append-to-body="true"></span>
<navbar name="dashboard-options" class="kibana-nav-options">
<div class="kibana-nav-info">
<span ng-show="dash.id" class="kibana-nav-info-title">
<span ng-bind="::dash.title"></span>
</span>
</div>

<div class="button-group kibana-nav-actions" role="toolbar">
<button ng-click="newDashboard()"
aria-label="New Dashboard">
<span>New</span>
</button>
<button
aria-label="Save Dashboard"
aria-haspopup="false"
aria-expanded="{{ configTemplate.is('save') }}"
ng-class="{active: configTemplate.is('save')}"
ng-click="configTemplate.toggle('save');">
<span>Save</span>
</button>
<button
aria-label="Load Saved Dashboard"
aria-haspopup="false"
aria-expanded="{{ configTemplate.is('load') }}"
ng-class="{active: configTemplate.is('load')}"
ng-click="configTemplate.toggle('load');">
<span>Open</span>
</button>
<button
aria-label="Share Dashboard"
aria-haspopup="false"
aria-expanded="{{ configTemplate.is('share') }}"
ng-class="{active: configTemplate.is('share')}"
ng-click="configTemplate.toggle('share');">
<span>Share</span>
</button>
<button
aria-label="Add Visualization"
aria-haspopup="false"
aria-expanded="{{ configTemplate.is('pickVis') }}"
ng-class="{active: configTemplate.is('pickVis')}"
ng-click="configTemplate.toggle('pickVis');">
<span>Add visualization</span>
</button>
<button
aria-label="Options"
aria-haspopup="false"
aria-expanded="{{ configTemplate.is('options') }}"
ng-class="{active: configTemplate.is('options')}"
ng-click="configTemplate.toggle('options');">
<span>Options</span>
</button>
<div class="chrome-actions"kbn-chrome-append-nav-controls></div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spinner needs to be moved out of kbn-chrome-append-nav-controls and into the overall chrome otherwise it will be missing in any application that doesn't use kbn-chrome-append-nav-controls.

</div>
</navbar>
<config config-template="configTemplate" config-object="opts"></config>

<navbar ng-show="chrome.getVisible()" name="dashboard-search">
<form name="queryInput"
class="fill inline-form"
ng-submit="filterResults()"
Expand Down Expand Up @@ -29,66 +84,9 @@
</div>

</form>

<div class="button-group" role="toolbar">
<kbn-tooltip text="New Dashboard" placement="bottom" append-to-body="1">
<button ng-click="newDashboard()" aria-label="New Dashboard"><i aria-hidden="true" class="fa fa-file-new-o"></i></button>
</kbn-tooltip>
<kbn-tooltip text="Save Dashboard" placement="bottom" append-to-body="1">
<button
aria-label="Save Dashboard"
aria-haspopup="true"
aria-expanded="{{ configTemplate.is('save') }}"
ng-class="{active: configTemplate.is('save')}"
ng-click="configTemplate.toggle('save');">
<i aria-hidden="true" class="fa fa-save"></i>
</button>
</kbn-tooltip>
<kbn-tooltip text="Load Saved Dashboard" placement="bottom" append-to-body="1">
<button
aria-label="Load Saved Dashboard"
aria-haspopup="true"
aria-expanded="{{ configTemplate.is('load') }}"
ng-class="{active: configTemplate.is('load')}"
ng-click="configTemplate.toggle('load');">
<i aria-hidden="true" class="fa fa-folder-open-o"></i>
</button>
</kbn-tooltip>
<kbn-tooltip text="Share" placement="bottom" append-to-body="1">
<button
aria-label="Share Dashboard"
aria-haspopup="true"
aria-expanded="{{ configTemplate.is('share') }}"
ng-class="{active: configTemplate.is('share')}"
ng-click="configTemplate.toggle('share');">
<i aria-hidden="true" class="fa fa-external-link"></i>
</button>
</kbn-tooltip>
<kbn-tooltip text="Add Visualization" placement="bottom" append-to-body="1">
<button
aria-label="Add Visualization"
aria-haspopup="true"
aria-expanded="{{ configTemplate.is('pickVis') }}"
ng-class="{active: configTemplate.is('pickVis')}"
ng-click="configTemplate.toggle('pickVis');">
<i aria-hidden="true" class="fa fa-plus-circle"></i>
</button>
</kbn-tooltip>
<kbn-tooltip text="Options" placement="bottom" append-to-body="1">
<button
aria-label="Options"
aria-haspopup="true"
aria-expanded="{{ configTemplate.is('options') }}"
ng-class="{active: configTemplate.is('options')}"
ng-click="configTemplate.toggle('options');">
<i aria-hidden="true" class="fa fa-gear"></i>
</button>
</kbn-tooltip>
</div>
<div class="button-group"></div>
</navbar>

<config config-template="configTemplate" config-object="opts"></config>

<filter-bar state="state"></filter-bar>

<div ng-show="!state.panels.length" class="text-center start-screen">
Expand Down
7 changes: 5 additions & 2 deletions src/plugins/kibana/public/dashboard/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ app.directive('dashboardApp', function (Notifier, courier, AppState, timefilter,
load: require('plugins/kibana/dashboard/partials/load_dashboard.html'),
share: require('plugins/kibana/dashboard/partials/share.html'),
pickVis: require('plugins/kibana/dashboard/partials/pick_visualization.html'),
options: require('plugins/kibana/dashboard/partials/options.html')
options: require('plugins/kibana/dashboard/partials/options.html'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can all of these be moved to import statements?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few require statements throughout the code bse as you can see above, I say we open an issue to get to all of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter: require('ui/chrome/config/filter.html'),
interval: require('ui/chrome/config/interval.html')
});

$scope.refresh = _.bindKey(courier, 'fetch');
Expand Down Expand Up @@ -239,7 +241,8 @@ app.directive('dashboardApp', function (Notifier, courier, AppState, timefilter,
ui: $state.options,
save: $scope.save,
addVis: $scope.addVis,
addSearch: $scope.addSearch
addSearch: $scope.addSearch,
timefilter: $scope.timefilter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed, the timepicker should just interact with the timefilter service when used in the context of the chrome. Of course the time picker should remain reusable since its only real purpose is it set properties of an object.

};

init();
Expand Down
Loading