Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana 5.0 navigation / layout tweaks #6387

Closed
29 of 30 tasks
panda01 opened this issue Mar 2, 2016 · 5 comments
Closed
29 of 30 tasks

Kibana 5.0 navigation / layout tweaks #6387

panda01 opened this issue Mar 2, 2016 · 5 comments

Comments

@panda01
Copy link
Contributor

panda01 commented Mar 2, 2016

This is remaining work for the new navigation / layout / skin design in 5.0. Original ticket here: #4837

Visual errors

  • Letters for apps in the sidebar aren't vertically centered.
  • new kibana logo
  • move the kbn-append-nav-controls to the sidebar
  • remove the timepicker from the nav-controls registry
  • remove the loading from kbn nav controls
  • settings page top nav
  • Dark Theme
  • visually positioning the new logo proper
  • move spinner to chrome

Code errors

  • failing Functional tests
  • normalize $appName-thing
    • Remove old denormalized styles
    • $appName-option
    • $appName-actions
    • $appName-info
    • $appName-title
    • $appName-search
  • remove timefilter from options on pages
    • discover
    • visualize/editor
  • remove kibana.gif
  • cleanup color, and size non variables in less
  • Use import statements where we have require
  • remove gif from BaseOptimizer.js
  • remove addLegend from visualize
  • remove to-body class
  • remove important statements

Up for discussion

  • remove hidden settings button, or move the current settings there?
  • do we want to persist Less line numbers?
  • what's up with getActiveTabId it now returns -none- all the time?
@panda01 panda01 added the v5.0.0 label Mar 2, 2016
@panda01 panda01 self-assigned this Mar 2, 2016
@tbragin
Copy link
Contributor

tbragin commented Mar 3, 2016

@panda01 Is the new design with both light and dark theme in scope for 5.0-alpha1?

cc: @simianhacker @rashidkpc

@panda01
Copy link
Contributor Author

panda01 commented Mar 3, 2016

Currently it isn't, will add it to the list though.
On Mar 3, 2016 19:25, "tbragin" [email protected] wrote:

@panda01 https://github.com/panda01 Is the new design with both light
and dark theme in scope for 5.0-alpha1?

cc: @simianhacker https://github.com/simianhacker @rashidkpc
https://github.com/rashidkpc


Reply to this email directly or view it on GitHub
#6387 (comment).

@tbragin tbragin changed the title Kibana 5.0 tweaks Kibana 5.0 navigation / layout tweaks Mar 10, 2016
@panda01
Copy link
Contributor Author

panda01 commented Mar 10, 2016

k5 0

@tylersmalley
Copy link
Contributor

I checked off failing Functional tests as #6536 will resolve it.

@panda01
Copy link
Contributor Author

panda01 commented Mar 31, 2016

These have been handled or discussed. No longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants