[Alerting] migrates acceptance and functional test fixtures to KP #64888

gmmorris · 2020-04-30T12:40:36Z

Summary

This PR migrates the vast majority of Alerting legacy code to the Kibana Platform.

This includes:

Removed legacy Task Manager
Migrates Fixture plugins in Alerting, Triggers UI and Task Manager Perf

This does not includes:

The PagerDuty simulator due to a lack of support for custom responses in the platform. issue opened. kibanaResponseFactory should support entirely custom responses #65045
The Webhooks simulator due to a lack of support for custom authorisation. Requires investigation.

closes #56537

Checklist

Delete any items that are not applicable to this PR.

~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~
~~This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...

gmmorris · 2020-05-04T14:44:31Z

@elasticmachine merge upstream

…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)

sorenlouv

apm changes lgtm

elasticmachine · 2020-05-05T14:25:32Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

pmuellr

LGTM

mikecote

LGTM! This is great, almost fully migrated! Just want to make sure there's a follow up alerting issue to cleanup the remaining few lines of code linking to the blocking platform issue.

mikecote · 2020-05-05T13:26:19Z

x-pack/typings/hapi.d.ts

@@ -22,6 +22,6 @@ declare module 'hapi' {
    security?: SecurityPlugin;
    actions?: ActionsPlugin;
    alerting?: AlertingPlugin;
-    task_manager?: LegacyTaskManagerApi;
+    task_manager?: TaskManager;


This is more in regards of "see something, say something" but you may know more than I do.

Are these types to define plugin properties within server.plugins in the legacy world? Where it would no longer be necessary for alerts, actions and task manager?

These extend the hapi server so that they can be passed in on the context.
I decided to leave it until that part of core is removed entirely which I expect platform will don once everyone has migrated.

I'll make sure there's an issue for the remaining bits

kibanamachine · 2020-05-05T18:49:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8fa763a

History

💚 Build #45081 succeeded 85a6679
💔 Build #45031 failed 801bd16
💔 Build #45009 failed 54a7597
💔 Build #44883 failed e1f83ef
💔 Build #44881 failed 7215df9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…astic#64888) This PR migrates the vast majority of Alerting legacy code to the Kibana Platform. This includes: 1. Removed legacy Task Manager 2. Migrates Fixture plugins in Alerting, Triggers UI and Task Manager Perf This does not includes: 1. The PagerDuty simulator due to a lack of support for custom responses in the platform. issue opened. elastic#65045 2. The Webhooks simulator due to a lack of support for custom authorisation. Requires investigation. # Conflicts: # renovate.json5 # x-pack/index.js

* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...

…4888) (#65430) This PR migrates the vast majority of Alerting legacy code to the Kibana Platform. This includes: 1. Removed legacy Task Manager 2. Migrates Fixture plugins in Alerting, Triggers UI and Task Manager Perf This does not includes: 1. The PagerDuty simulator due to a lack of support for custom responses in the platform. issue opened. #65045 2. The Webhooks simulator due to a lack of support for custom authorisation. Requires investigation.

gmmorris added 4 commits April 30, 2020 13:01

migrated alerting FTs fixtures to NP

fb1f38a

removed legacy TM

798d38f

migrated alerting fixtures to NP

0849331

migrated TM perf fixture to NP

955dfd5

gmmorris mentioned this pull request Apr 30, 2020

Alerting/np migration tests #64527

Closed

7 tasks

gmmorris added 7 commits April 30, 2020 16:19

correct typing around TM

804eb67

added tsconfig build

a266452

add types to root xpack package.json

bd584a9

reapplied changes after merge conflict

e1f83ef

fixed import

5d013e0

yarn lock updates

54a7597

elasticmachine and others added 4 commits May 4, 2020 10:44

Merge branch 'master' into alerting/np-tests-migration

801bd16

migrate jira simulator

67a885b

updated config

48cbde4

gmmorris marked this pull request as ready for review May 5, 2020 09:00

gmmorris requested review from a team as code owners May 5, 2020 09:00

sorenlouv approved these changes May 5, 2020

View reviewed changes

mikecote self-requested a review May 5, 2020 13:18

gmmorris added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v8.0.0 labels May 5, 2020

pmuellr approved these changes May 5, 2020

View reviewed changes

mikecote approved these changes May 5, 2020

View reviewed changes

Merge branch 'master' into alerting/np-tests-migration

8fa763a

gmmorris merged commit 94127d8 into elastic:master May 6, 2020

gmmorris mentioned this pull request May 6, 2020

[7.x] [Alerting] migrates acceptance and functional test fixtures to KP (#64888) #65430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] migrates acceptance and functional test fixtures to KP #64888

[Alerting] migrates acceptance and functional test fixtures to KP #64888

gmmorris commented Apr 30, 2020 •

edited

Loading

gmmorris commented May 4, 2020

sorenlouv left a comment

elasticmachine commented May 5, 2020

pmuellr left a comment

mikecote left a comment

mikecote May 5, 2020

gmmorris May 5, 2020

gmmorris May 5, 2020

kibanamachine commented May 5, 2020

[Alerting] migrates acceptance and functional test fixtures to KP #64888

[Alerting] migrates acceptance and functional test fixtures to KP #64888

Conversation

gmmorris commented Apr 30, 2020 • edited Loading

Summary

Checklist

For maintainers

gmmorris commented May 4, 2020

sorenlouv left a comment

Choose a reason for hiding this comment

elasticmachine commented May 5, 2020

pmuellr left a comment

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

mikecote May 5, 2020

Choose a reason for hiding this comment

gmmorris May 5, 2020

Choose a reason for hiding this comment

gmmorris May 5, 2020

Choose a reason for hiding this comment

kibanamachine commented May 5, 2020

💚 Build Succeeded

History

gmmorris commented Apr 30, 2020 •

edited

Loading