Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Adds refresh and autoplay options to view menu #64375

Merged
merged 8 commits into from
Apr 30, 2020
Merged

[Canvas] Adds refresh and autoplay options to view menu #64375

merged 8 commits into from
Apr 30, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 23, 2020 •
edited
Loading

Summary

Related to #35873.

This removes the Options menu and splits up the refresh and autoplay settings into separate menu options under the View menu.

Before:

Options menu

Screen Shot 2020-04-27 at 10 51 45 AM

After:

View menu

Screen Shot 2020-04-27 at 4 46 49 PM

Auto refresh settings menu

Screen Shot 2020-04-27 at 4 47 16 PM

Autoplay settings menu

Screen Shot 2020-04-27 at 4 47 50 PM

Changes:

  • Removes Option menu
  • Adds separate refresh and autoplay settings options
  • Removes manual refresh button from auto refresh settings
  • Removes autoplay toggle switch from autoplay settings
  • Adds toggle autoplay menu option
  • Updates canvas security functional tests
  • Removes ControlSettings component

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added the WIP Work in progress label Apr 23, 2020
@cqliu1 cqliu1 force-pushed the canvas/view-menu branch from 9cf5484 to 2a277b8 Compare April 27, 2020 17:51
@ryankeairns
Copy link
Contributor

This is looking much better, thank you! Splitting the panel up into two sections makes things easier to understand. The functionality still works as it did before. Just a few small UI suggestions:

  1. I mentioned this on Slack, but the associated issue shows the use of dividers and has a slightly different order for the links

  2. There is a spacer that can be removed here:

image

  1. The pause icon is kinda funny looking... maybe we should use the square stop icon instead?

image

@ryankeairns
Copy link
Contributor

Missed one...

  1. This list of presets feels rather long. I would be ok with matching it to the Autoplay settings or just trimming ~5. It's easy enough to use the custom input.

image

@cqliu1 cqliu1 force-pushed the canvas/view-menu branch from abb34b7 to c4e763b Compare April 28, 2020 19:48
@cqliu1 cqliu1 force-pushed the canvas/view-menu branch from c4e763b to b36f98d Compare April 29, 2020 03:39
@cqliu1 cqliu1 added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@cqliu1 cqliu1 added enhancement New value added to drive a business result impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort release_note:enhancement review v7.8.0 v8.0.0 and removed WIP Work in progress labels Apr 29, 2020
@cqliu1 cqliu1 marked this pull request as ready for review April 29, 2020 16:21
@cqliu1 cqliu1 requested review from a team as code owners April 29, 2020 16:21
ryankeairns
ryankeairns approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Two things I noticed...

  1. I know we've discussed this before, but it feels weird to me that the show/hide editing controls are not in sync. More specifically, I would favor showing the eyeClosed icon in the upper right by default. As it currently stands, the top menu shows eye at the same time the View menu link shows the eyeClosed.
  2. Is Zoom > Fit to window working for you? I'm going to guess this pre-existed and could be a separate issue.

Thanks!

crob611
crob611 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@crob611
Copy link
Contributor

crob611 commented Apr 30, 2020

It's always annoyed me that you can pick a time for autoplay, but you still have to push "Start Autoplay" for it to work. It doesn't match how AutoRefresh works. Maybe not in this PR, but should we change up Autoplay so that it works the same as AutoRefresh. Just pick a time and it's on, or pick manually and it's off. @ryankeairns

@cqliu1
Copy link
Contributor Author

cqliu1 commented Apr 30, 2020

should we change up Autoplay so that it works the same as AutoRefresh

++ I was thinking that too. It makes a lot of sense to make the UX for both forms the same.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 127b324 into elastic:master Apr 30, 2020
@cqliu1 cqliu1 deleted the canvas/view-menu branch April 30, 2020 21:45
This was referenced Apr 30, 2020
Merged
Closed
cqliu1 added a commit that referenced this pull request May 1, 2020
@cqliu1
[7.x] [Canvas] Adds refresh and autoplay options to view menu (#64375) (
55a2d67 
#64972)
v1v added a commit to v1v/kibana that referenced this pull request May 4, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
0dd3b32 
* upstream/master: (315 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
68c12f9 
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (51 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/common/types.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'master' into alerting/np-tests-migration
7215df9 
* master: (44 commits)
  onEvent prop for expression component (elastic#64995)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
enhancement New value added to drive a business result impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort release_note:enhancement review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cqliu1 @ryankeairns @elasticmachine @crob611 @kibanamachine