Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding daily_model_snapshot_retention_after_days to types and schemas #65417

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented May 6, 2020

Follow up to #65377 and #65405.

Fixes regression introduced by elastic/elasticsearch#56125 and adds daily_model_snapshot_retention_after_days to the API schema definitions.

For maintainers

@walterra walterra added :ml Feature:Anomaly Detection ML anomaly detection regression release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested review from peteharverson and walterra May 6, 2020 07:18
@walterra walterra marked this pull request as ready for review May 6, 2020 07:22
@walterra walterra requested a review from a team as a code owner May 6, 2020 07:22
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 8944dba into elastic:master May 6, 2020
@jgowdyelastic jgowdyelastic deleted the adding-daily_model_snapshot_retention_after_days-to-schemas branch May 6, 2020 09:22
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 6, 2020
* master: (72 commits)
  add tsvb tests to Firefox suite (elastic#65425)
  Fix flaky ServerMetricsCollector integration test (elastic#65420)
  [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428)
  [ML] Adds docs_per_second to transform edit form. (elastic#65365)
  update apm index pattern (elastic#65424)
  add direct build command (elastic#65431)
  [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417)
  [chore] Improve request cancelation handling in vis embeddable (elastic#65057)
  [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888)
  [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290)
  Additional branding updates (elastic#64712)
  Remove redundant formatting of percentage column (elastic#64948)
  [SIEM][CASE] Configuration pages UI redesign (elastic#65355)
  New nav (elastic#64018)
  [Ingest pipelines] Address copy feedback (elastic#65175)
  bug fixing (elastic#65387)
  skip whole suite blocking snapshots (elastic#65377)
  add related event generation to ancestor nodes (fixes a bug) (elastic#64950)
  [Canvas] move files from legacy/plugins to plugins (elastic#65283)
  [SIEM] template timeline UI (elastic#64439)
  ...
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 6, 2020
@walterra walterra added the v7.9.0 label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants