Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] CASES Bugs BC2 #62170

Merged
merged 9 commits into from
Apr 1, 2020
Merged

[SIEM] CASES Bugs BC2 #62170

merged 9 commits into from
Apr 1, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 1, 2020 •
edited
Loading

Summary

@cnasikas cnasikas mentioned this pull request Apr 1, 2020
Closed
3 tasks
@XavierM XavierM marked this pull request as ready for review April 1, 2020 15:08
@XavierM XavierM requested a review from a team as a code owner April 1, 2020 15:08
@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v7.8.0 v8.0.0 labels Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

stephmilovic
stephmilovic approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review ✅ manual testing ✅ LGTM!

@XavierM XavierM requested a review from stephmilovic April 1, 2020 18:45
stephmilovic
stephmilovic approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a second pass at the code and manual testing and.... it looks great! All signals say LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit b1a39ce into elastic:master Apr 1, 2020
@XavierM XavierM mentioned this pull request Apr 1, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Apr 1, 2020
@XavierM @cnasikas
[SIEM] CASES Bugs BC2 (elastic#62170)
7fccad4 
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <[email protected]>
@XavierM XavierM mentioned this pull request Apr 1, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Apr 1, 2020
@XavierM @cnasikas
[SIEM] CASES Bugs BC2 (elastic#62170)
4e671d7 
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
3cc9ed4 
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
XavierM added a commit that referenced this pull request Apr 2, 2020
@XavierM @cnasikas
[SIEM] CASES Bugs BC2 (#62170) (#62232)
954c367 
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <[email protected]>

Co-authored-by: Christos Nasikas <[email protected]>
XavierM added a commit that referenced this pull request Apr 2, 2020
@XavierM @cnasikas
[SIEM] CASES Bugs BC2 (#62170) (#62231)
5c1516c 
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <[email protected]>

Co-authored-by: Christos Nasikas <[email protected]>
@XavierM XavierM deleted the siem-case-bugs-bc2 branch June 4, 2020 16:05
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @kibanamachine @stephmilovic @MindyRS @cnasikas