Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Optimize get latest monitor API #61820

Merged
merged 6 commits into from
Apr 2, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #56865

Remove uncessary aggs from getLatestMonitor API.

Also removed getMonitorAPI, since we can pick ID from URL Params to display.

@shahzad31 shahzad31 added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.8 labels Mar 30, 2020
@shahzad31 shahzad31 requested a review from justinkambic March 30, 2020 14:29
@shahzad31 shahzad31 self-assigned this Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 changed the title Optimize get monitor [Uptime] Optimize get latest monitor API Mar 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from andrewvc April 1, 2020 16:50
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice cleanup, and I like the move to hooks as well.

@shahzad31 shahzad31 merged commit df655c9 into elastic:master Apr 2, 2020
@shahzad31 shahzad31 deleted the optimize-get-monitor branch April 2, 2020 06:31
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Apr 2, 2020
* update monitor status API

* update fixture

* fix types

* fix tets

* fix tests
shahzad31 added a commit that referenced this pull request Apr 2, 2020
* update monitor status API

* update fixture

* fix types

* fix tets

* fix tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
@rayafratkina rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Optimize getLatestMonitor adapter function
5 participants