Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] [Detection Engine] Fixes all rules sorting #62039

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Mar 31, 2020

Summary

Rule activity monitoring disabled sorting. This PR enables sorting to what it was in 7.6.1. Unfortunately, sorting broke in 7.6.1 and is still broken in 7.6.2. Need to do further investigation at some point. d43b8dc fixes #61624 sorting back to 7.6.0 functionality.

7.6.0 sorting:
7-6-0-rules-sorting

7.6.1 / 7.6.2 sorting (sorts once, won't sort after first click):
7-6-1-rules-sorting

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

@dhurley14 dhurley14 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 31, 2020
@dhurley14 dhurley14 self-assigned this Mar 31, 2020
@dhurley14 dhurley14 changed the title [SIEM] [Detection Engine] Fixes sorting to what it was in 7.6.1 [SIEM] [Detection Engine] Fixes all rules sorting to what it was in 7.6.1 Mar 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

…able column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
@dhurley14 dhurley14 force-pushed the fix-sortable-rules-table branch from 99d8cd3 to d43b8dc Compare April 1, 2020 16:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #37609 failed 22f6ebe24fc4eb421820bccf15c4b3a5b3e78850

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14
Copy link
Contributor Author

Thanks @yctercero and @XavierM for your debugging efforts!

@dhurley14 dhurley14 changed the title [SIEM] [Detection Engine] Fixes all rules sorting to what it was in 7.6.1 [SIEM] [Detection Engine] Fixes all rules sorting Apr 1, 2020
@dhurley14 dhurley14 marked this pull request as ready for review April 1, 2020 20:15
@dhurley14 dhurley14 requested a review from a team as a code owner April 1, 2020 20:15
Comment on lines +69 to +72
// for future devs: eui basic table is not giving us a prop to set the value, so
// we are using the ref in setTimeout to reset on the next loop so that we
// do not get a warning telling us we are trying to update during a render
window.setTimeout(() => tableRef?.current?.changeSelection([]), 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out our future selves! 😅

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally and sorting is functioning as intended! Thanks for the fix and additional comments around why as well -- LGTM! 👍

@dhurley14 dhurley14 merged commit cb914d4 into elastic:master Apr 1, 2020
@dhurley14 dhurley14 deleted the fix-sortable-rules-table branch April 1, 2020 20:45
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 1, 2020
* fixes sorting to what it was in 7.6.1

* removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 1, 2020
* fixes sorting to what it was in 7.6.1

* removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIEM] [Detection Engine] Can not sort by "last run" or "activated" on rules table
5 participants