-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/design master merge #6171
Closed
tsullivan
wants to merge
134
commits into
elastic:feature/design
from
tsullivan:feature/design-master-merge
Closed
Feature/design master merge #6171
tsullivan
wants to merge
134
commits into
elastic:feature/design
from
tsullivan:feature/design-master-merge
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just activated for Metric vis. First version needing improvements in the params handling.
…d more isolated changes.
Use const/let instead of var in all core plugins
Disable browser auto-complete in favor of module autocomplete
make only spy tab clickable, not entire row
tsullivan
added
review
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
labels
Feb 10, 2016
Build failed. I'll have to see if the functional tests normally pass in this branch |
It can't find |
Going file another PR. Somehow that |
This was referenced Feb 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging latest master into feature/design. Let's see if it builds!