es6 modules 1 - hoist private module providers #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I stopped the build on this one because it had a bunch of timeout failures. |
spalger
changed the title
…ideEffects es6 modules 4 - fix import side effects
es6 modules 3 - hoist commonly inlined modules
es6 modules 2 - unwrap amd modules
|
This needs to be rebased |
spalger
force-pushed
the
implement/es6Modules/privateProviders
branch
from
5e2c8c2 to
e503473
Compare
…Modules/privateProviders
spalger
force-pushed
the
implement/es6Modules/privateProviders
branch
from
e503473 to
e958c87
Compare
|
I guess this needs to be rebased again... |
…Modules/privateProviders
|
LGTM, but you should definitely get another pair of eyes on this. |
|
#yolo |
w33ble
added a commit
that referenced
this pull request
Feb 8, 2016
…viders es6 modules 1 - hoist private module providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6099
Find all usage of
Private(require('...'));and convert it into two things:at the top/under the other imports of a file:
replace the original statements with: