es6 modules 2 - unwrap amd modules #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
changed the title
|
For reviewers: I strongly recommend using github's remove-whitespace feature when looking through the diff: https://github.com/elastic/kibana/pull/6099/files?w=1 |
|
This might be my favorite PR ever. LGTM |
Looks like good coding conventions made it possible to search/replace programatically, and I think that's awesome. LGTM |
|
🎉 |
…ideEffects es6 modules 4 - fix import side effects
es6 modules 3 - hoist commonly inlined modules
spalger
added a commit
that referenced
this pull request
Feb 6, 2016
es6 modules 2 - unwrap amd modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6100
AMD is incompatible with es6 modules, this removes the define() wrapper function and exports the first return value as the default export.