Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable browser auto-complete in favor of module autocomplete #6049

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

RubieV
Copy link
Contributor

@RubieV RubieV commented Jan 29, 2016

During the ElasticSearch meetup I saw @cwurm struggling with his browser auto-complete that hindered his view. I could not stand all those struggles, so hereby I present a single line of code change that disables the browser auto complete that currently overlays Kibana saved object finder's auto-complete.

Thanks for the conversation Wednesday in Eindhoven, see you next time!

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@epixa
Copy link
Contributor

epixa commented Jan 29, 2016

jenkins, test it

@RubieV
Copy link
Contributor Author

RubieV commented Jan 29, 2016

Would be great if it can be merged downstream to 4.2, any possibility?

@epixa
Copy link
Contributor

epixa commented Jan 29, 2016

@RubieV To be complete honest, it's unlikely. At this point, we don't anticipate any additional releases on the 4.2 line.

@cwurm
Copy link
Contributor

cwurm commented Jan 30, 2016

Wow, never before has one of my talks led to a PR. Thanks a lot, @RubieV!

@epixa
Copy link
Contributor

epixa commented Feb 2, 2016

LGTM. Thanks for the PR!

epixa added a commit that referenced this pull request Feb 2, 2016
Disable browser auto-complete in favor of module autocomplete
@epixa epixa merged commit 1ba65b0 into elastic:master Feb 2, 2016
@elasticsearch-bot
Copy link

courtewing merged this into the following branches!

Branch Commits
4.x f29b7af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants