Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Key on Search auto-fills previous query #5311

Closed
timander opened this issue Nov 4, 2015 · 8 comments
Closed

Enter Key on Search auto-fills previous query #5311

timander opened this issue Nov 4, 2015 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience v5.0.0

Comments

@timander
Copy link

timander commented Nov 4, 2015

Kibana
Version 4.1.2
Build 7562
Commit SHA 34af16e

When I hit enter with a query in the search bar with "app:MyApp AND env:DEV"
And view search results
And change my query to "app:MyApp"
When I press enter
Then search results should NOT AUTO-FILL MY PREVIOUS QUERY!

@rashidkpc
Copy link
Contributor

Worth discussing this, I go back and forth on it. Some auto complete systems do this, others don't, for example, Chrome's URL auto complete behaves in this manner, but google's search bar does not.

I probably agree with @timander on this one.

@timander
Copy link
Author

timander commented Nov 4, 2015

If I want the previous auto-fill query, I will hit the down arrow on the auto-suggest before hitting enter. It's frustratingly impossible to change my query. Luckily, I have another appender still logging to a Kibana 3 instance still where it's not borken.

@asaed
Copy link

asaed commented Nov 4, 2015

I agree with @timander the current behavior is counter intuitive

@mvphelps
Copy link

mvphelps commented Nov 5, 2015

+1 @timander

@jonny561201
Copy link

+1 @timander

When you spend a lot of time searching through logs these types of minor inconveniences can start to add up, but ultimately it just seems counter intuitive.

@meustrus
Copy link

meustrus commented Nov 5, 2015

+1 @timander

@skrawcz
Copy link

skrawcz commented Aug 24, 2016

+1 in 4.1.2-es-2.0 with chrome it's particularly aggressive!!

@tbragin
Copy link
Contributor

tbragin commented Jan 10, 2017

I tried to see how this works in 5.1.1, and it appears to no longer work as described in this issue:

  • type in "app:MyApp AND env:DEV" in discover search bar
  • type in "app:MyApp"
  • press enter
  • "app:MyApp" gets chosen

Perhaps it was addressed by this PR? #6049

Closing - please comment or re-open if you still see this issue in 5.x

@tbragin tbragin closed this as completed Jan 10, 2017
@tbragin tbragin added bug Fixes for quality problems that affect the customer experience v5.0.0 and removed discuss labels Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience v5.0.0
Projects
None yet
Development

No branches or pull requests

9 participants