Fix visual baseline job #59348
Merged
Fix visual baseline job #59348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/visual-baseline-job
branch
from
1cf8669 to
24f88a0
Compare
spalger
force-pushed
the
fix/visual-baseline-job
branch
from
cd5d943 to
d20a8b0
Compare
|
On d20a8b0 you can see the status of running the |
|
@elasticmachine merge upstream |
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Mar 5, 2020
| source "$KIBANA_DIR/src/dev/ci_setup/setup_percy.sh" | ||
|
|
||
| checks-reporter-with-killswitch "Kibana visual regression tests" \ | ||
| yarn run percy exec -t 500 \ | ||
| echo " -> building and extracting OSS Kibana distributable for use in functional tests" |
There was a problem hiding this comment.
I'll plan to take a pass over these shell scripts to clean them up at some point, so that this doesn't need to be duplicated
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 5, 2020
* Establish Percy baselines * move Jenkinsfile changed back to `.ci` directory * rename xpack workers Co-authored-by: Elastic Machine <[email protected]>
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 5, 2020
* Establish Percy baselines * move Jenkinsfile changed back to `.ci` directory * rename xpack workers Co-authored-by: Elastic Machine <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Establish Percy baselines * move Jenkinsfile changed back to `.ci` directory * rename xpack workers Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 6, 2020
…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
spalger
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Establish Percy baselines * move Jenkinsfile changed back to `.ci` directory * rename xpack workers Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the visual baseline job in #52154 but it doesn't work (intended) and now that the Jenkins related changes are complete I'm working on getting the job functional.
This updates the
.ci/Jenkinsfile_visual_baselinefile to run thetest/scripts/jenkins_visual_regression.shandtest/scripts/jenkins_xpack_visual_regression.shscripts, which both build Kibana and run the visual regression suites.The primary goal with this PR is to start running the visual baseline job regularly so we can measure stability in the baseline and then move forward with further optimizations and changes necessary to start using this baseline in testing.