-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Create settings page to manage Custom Links #57788
[APM] Create settings page to manage Custom Links #57788
Conversation
e4905a7
to
d77cf8c
Compare
...gins/apm/public/components/app/Settings/AgentConfigurations/AddEditFlyout/ServiceSection.tsx
Show resolved
Hide resolved
...ponents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/ActionSection.tsx
Outdated
Show resolved
Hide resolved
...ponents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/ActionSection.tsx
Outdated
Show resolved
Hide resolved
...onents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some quick style and copy suggestions. I found that the validation check and message on the label
form field a little off what we'd usually show. Typically, we'd show an error message under the form field and show a red highlight (like in the validation in filters below)
Not sure if that's just temporary or not.
...blic/components/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/index.tsx
Outdated
Show resolved
Hide resolved
...onents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
...blic/components/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/index.tsx
Outdated
Show resolved
Hide resolved
...blic/components/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/index.tsx
Outdated
Show resolved
Hide resolved
...blic/components/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/index.tsx
Outdated
Show resolved
Hide resolved
@formgeist The field isn't red because it is focused. The tooltip is automatically added when |
I think we should show as a help text |
...onents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
...ponents/app/Settings/CustomizeUI/CustomActionsOverview/CustomActionsFlyout/ActionSection.tsx
Outdated
Show resolved
Hide resolved
6c46d85
to
dac5b46
Compare
.../apm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/DeleteButton.tsx
Outdated
Show resolved
Hide resolved
return useMemo(() => { | ||
return createCallApmApi(http); | ||
}, [http]); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, beautiful! Love seeing this thing gone. Good work 👍
375406a
to
0e57330
Compare
5cea14c
to
718fdf5
Compare
x-pack/legacy/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx
Outdated
Show resolved
Hide resolved
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Show resolved
Hide resolved
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Feel free to merge but as a follow up I think you should write an API test. For inspiration you can look at the test I wrote for agent configuration. Should be very similar:
oh, and remember to add these new APIs to the feature controls test:
https://github.com/elastic/kibana/blob/b83f81458c11cbb890023e662920f3679c615ab7/x-pack/test/api_integration/apis/apm/feature_controls.ts
You can find the instructions for running the API tests here https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/readme.md#api-integration-tests |
I created a new issue #59528 to add tests for the new API. |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "before all" hook for "should return 403 for hiddentype doc"Standard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "after all" hook for "should return 403 for hiddentype doc"Standard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "before all" hook for "should return 403 for hiddentype doc"Standard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
* creating custom action index * reverting service form to service section * creating useForm hooks and fields section * adding react-hook-form * refactoring * validating filters * fixing imports * refactoring to NP and creating save custom action * creating basic apis for custom actions * refactoring * changing custom action filters type * adding delete option * removing useForm * fixing flyout view * filters are invalid when selecting the default value * ui fixes * ui fixes * fixing typescript * fixing typescript * fixing labels and adding space btw components * refactoring filters structure * removing reach-hook-form * removing reach-hook-form * adding unit tests * adding unit tests * create custom action index * adding filter option * refactoring create index, creating filter links * creating list api * rename custom action to custom link * fixing unit tests * adding unit tests * refactoring callApmApi * removing useCallApmApi hook * Rename Flyoutfooter.tsx to FlyoutFooter.tsx * removing unused import * fixing typescript errors * fixing duplicate messages * removing filters * fixing save functionality * fixing pr comments * fixing pr comments
…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
* creating custom action index * reverting service form to service section * creating useForm hooks and fields section * adding react-hook-form * refactoring * validating filters * fixing imports * refactoring to NP and creating save custom action * creating basic apis for custom actions * refactoring * changing custom action filters type * adding delete option * removing useForm * fixing flyout view * filters are invalid when selecting the default value * ui fixes * ui fixes * fixing typescript * fixing typescript * fixing labels and adding space btw components * refactoring filters structure * removing reach-hook-form * removing reach-hook-form * adding unit tests * adding unit tests * create custom action index * adding filter option * refactoring create index, creating filter links * creating list api * rename custom action to custom link * fixing unit tests * adding unit tests * refactoring callApmApi * removing useCallApmApi hook * Rename Flyoutfooter.tsx to FlyoutFooter.tsx * removing unused import * fixing typescript errors * fixing duplicate messages * removing filters * fixing save functionality * fixing pr comments * fixing pr comments Co-authored-by: Elastic Machine <[email protected]>
closes #56368
closes #56365
Empty prompt shows when no filters are found.
Create custom link flyout
List of custom links
Edit/Delete custom link