[SIEM] [CASES] API with io-ts validation #59265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al comments via comment_ids, be able to delete multiple cases/comments
|
Pinging @elastic/siem (Team:SIEM) |
stephmilovic
reviewed
Mar 4, 2020
x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/api.ts
Outdated
Show resolved
Hide resolved
3 tasks
stephmilovic
reviewed
Mar 5, 2020
stephmilovic
reviewed
Mar 5, 2020
stephmilovic
reviewed
Mar 5, 2020
stephmilovic
reviewed
Mar 5, 2020
x-pack/plugins/case/server/routes/api/__fixtures__/create_mock_so_repository.ts
Show resolved
Hide resolved
stephmilovic
reviewed
Mar 5, 2020
x-pack/plugins/case/server/routes/api/cases/comments/delete_comment.test.ts
Outdated
Show resolved
Hide resolved
stephmilovic
reviewed
Mar 5, 2020
x-pack/plugins/case/server/routes/api/cases/comments/get_comment.ts
Outdated
Show resolved
Hide resolved
stephmilovic
reviewed
Mar 5, 2020
stephmilovic
reviewed
Mar 5, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/add_comment/index.tsx
Show resolved
Hide resolved
stephmilovic
reviewed
Mar 5, 2020
stephmilovic
reviewed
Mar 5, 2020
x-pack/legacy/plugins/siem/public/containers/case/use_post_case.tsx
Outdated
Show resolved
Hide resolved
3 tasks
stephmilovic
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Awesome work @XavierM ! Thanks for all the cleanups, much easier with the new types. LGTM 🚀 🎸
| }; | ||
| const response = await KibanaServices.get().http.fetch(`${CASES_URL}`, { | ||
| const response = await KibanaServices.get().http.fetch<CasesResponse>(`${CASES_URL}/_find`, { |
There was a problem hiding this comment.
that's the way we did it for rules and it also matches what API call we are using under the hood of a saved object.
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Mar 6, 2020
* refactor to use io-ts, to be able to have ressource with sub, add total comments via comment_ids, be able to delete multiple cases/comments * fix test * adapt UI to refactor of the API * put it back the way it was * clean up to get cases * review I * review II - bring back url parameter * fix merge Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 6, 2020
…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
XavierM
added a commit
that referenced
this pull request
Mar 6, 2020
* refactor to use io-ts, to be able to have ressource with sub, add total comments via comment_ids, be able to delete multiple cases/comments * fix test * adapt UI to refactor of the API * put it back the way it was * clean up to get cases * review I * review II - bring back url parameter * fix merge Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
casesandcases-commentsto remove dependency in SIEM's foldercomment_idsChecklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers