Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Median aggregation labels now show "Median" instead of "50th percentile of" in Visualize #58521

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

wylieconlon
Copy link
Contributor

Release note

Median aggregation labels now show "Median" instead of "50th percentile of" in Visualize. Custom labels are also used.

Screenshot 2020-02-25 14 44 13

Screenshot 2020-02-25 14 44 23

Closes #18912

Checklist

Delete any items that are not applicable to this PR.

@wylieconlon wylieconlon added release_note:enhancement Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.7.0 labels Feb 25, 2020
@wylieconlon wylieconlon requested a review from a team as a code owner February 25, 2020 19:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this change the label from 50th percentile of bytes to median bytes ? the makeLabel function seems correct ?

},
},
],
getResponseAggs: percentilesMetricAgg.getResponseAggs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only needed for multi-value aggs. Replaced by getValue.

@wylieconlon
Copy link
Contributor Author

@ppisljar This changes the median aggConfig to a single-value config instead of multi-value percentiles aggregation. The multi-value aggregation had its own labeling function, so by removing that we get the expected labels.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon wylieconlon merged commit 613e4b9 into elastic:master Feb 26, 2020
@wylieconlon wylieconlon deleted the median-agg-label branch February 26, 2020 16:33
wylieconlon pushed a commit that referenced this pull request Feb 26, 2020
…58612)

* Median label shows "Median" instead of "50th percentile of"

* Update test

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@rayafratkina rayafratkina changed the title Median label shows "Median" instead of "50th percentile of" Median aggregation labels now show "Median" instead of "50th percentile of" in Visualize Apr 15, 2020
@kibanamachine
Copy link
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is rendered

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:42]         └-: discover app
[00:01:42]           └-> "before all" hook
[00:01:42]           └-> "before all" hook
[00:09:15]           └-: errors
[00:09:15]             └-> "before all" hook
[00:09:15]             └-> "before all" hook
[00:09:15]               │ info [logstash_functional] Loading "mappings.json"
[00:09:15]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:15]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:15]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:15]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:16]               │ info [invalid_scripted_field] Loading "mappings.json"
[00:09:16]               │ info [invalid_scripted_field] Loading "data.json.gz"
[00:09:16]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/6YA3Ba7URuedrm1tQ1gnpg] deleting index
[00:09:16]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_1/XMyzaXjeQZOpV7oljgnmjw] deleting index
[00:09:16]               │ info [invalid_scripted_field] Deleted existing index [".kibana_2",".kibana_1"]
[00:09:16]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:16]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:09:16]               │ info [invalid_scripted_field] Created index ".kibana"
[00:09:16]               │ debg [invalid_scripted_field] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:09:16]               │ info [invalid_scripted_field] Indexed 2 docs into ".kibana"
[00:09:17]               │ info Creating index .kibana_2.
[00:09:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:17]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:17]               │ info Reindexing .kibana to .kibana_1
[00:09:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:17]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:17]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] updating number_of_replicas to [0] for indices [.kibana_1]
[00:09:17]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] 8256 finished with response BulkByScrollResponse[took=23.7ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:09:17]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana/pirsswRKSWivmu9XHjt6jA] deleting index
[00:09:17]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:09:17]               │ debg Migrating saved objects config:7.0.0-alpha1, index-pattern:18ea0c30-2d77-11e8-93f2-6f8a391f33ef
[00:09:17]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/DGbxaXsxQaqUNKjKKnVDbg] update_mapping [_doc]
[00:09:17]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/DGbxaXsxQaqUNKjKKnVDbg] update_mapping [_doc]
[00:09:17]               │ info Pointing alias .kibana to .kibana_2.
[00:09:17]               │ info Finished in 457ms.
[00:09:17]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:09:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/DGbxaXsxQaqUNKjKKnVDbg] update_mapping [_doc]
[00:09:19]               │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:19]               │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:19]               │ debg ... sleep(700) start
[00:09:19]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586960545849#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:19]               │
[00:09:19]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:19]               │ debg ... sleep(700) end
[00:09:19]               │ debg returned from get, calling refresh
[00:09:20]               │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:20]               │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:20]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:20]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586960545849#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:20]               │
[00:09:20]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:22]               │ debg TestSubjects.find(kibanaChrome)
[00:09:22]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:22]               │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 62:139970 "INFO: 2020-04-15T14:22:28Z
[00:09:22]               │        Adding connection to http://localhost:6161/elasticsearch
[00:09:22]               │
[00:09:22]               │      "
[00:09:22]               │ debg ... sleep(501) start
[00:09:23]               │ debg ... sleep(501) end
[00:09:23]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:23]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:09:23]               │ debg ... sleep(501) start
[00:09:24]               │ debg ... sleep(501) end
[00:09:24]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:24]               │ debg TestSubjects.exists(statusPageContainer)
[00:09:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:26]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:27]             └-: invalid scripted field error
[00:09:27]               └-> "before all" hook
[00:09:27]               └-> is rendered
[00:09:27]                 └-> "before each" hook: global before each
[00:09:27]                 │ debg TestSubjects.exists(discoverFetchError)
[00:09:27]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverFetchError"]') with timeout=2500
[00:09:29]                 │ debg --- retry.tryForTime error: [data-test-subj="discoverFetchError"] is not displayed
[00:09:30]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app errors invalid scripted field error is rendered.png"
[00:09:30]                 │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:30]                 │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app errors invalid scripted field error is rendered.html
[00:09:30]                 └- ✖ fail: "discover app errors invalid scripted field error is rendered"
[00:09:30]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/discover/_errors.js:41:40)

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running with es instance 'yarn start' should result in the spec plugin being initialized on kibana's stdout

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/54481


Stack Trace

Error: Command failed with exit code 126: ./bin/elasticsearch-keystore create
    at makeError (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/lib/error.js:56:11)
    at handlePromise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/index.js:114:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is rendered

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:46]         └-: discover app
[00:01:46]           └-> "before all" hook
[00:01:46]           └-> "before all" hook
[00:09:36]           └-: errors
[00:09:36]             └-> "before all" hook
[00:09:36]             └-> "before all" hook
[00:09:36]               │ info [logstash_functional] Loading "mappings.json"
[00:09:36]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:36]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:36]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:36]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:37]               │ info [invalid_scripted_field] Loading "mappings.json"
[00:09:37]               │ info [invalid_scripted_field] Loading "data.json.gz"
[00:09:37]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/podcroh2RyOAvg4dfVeurA] deleting index
[00:09:37]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_1/KTihir7PTuef1WIDl8-YyA] deleting index
[00:09:37]               │ info [invalid_scripted_field] Deleted existing index [".kibana_2",".kibana_1"]
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:09:37]               │ info [invalid_scripted_field] Created index ".kibana"
[00:09:37]               │ debg [invalid_scripted_field] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:09:37]               │ info [invalid_scripted_field] Indexed 2 docs into ".kibana"
[00:09:37]               │ info Creating index .kibana_2.
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:37]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:37]               │ info Reindexing .kibana to .kibana_1
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] applying create index request using v1 templates []
[00:09:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:37]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] updating number_of_replicas to [0] for indices [.kibana_1]
[00:09:37]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] 8299 finished with response BulkByScrollResponse[took=17.6ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:09:38]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana/GlL1pmlbSqiQytuqMTGamQ] deleting index
[00:09:38]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:09:38]               │ debg Migrating saved objects config:7.0.0-alpha1, index-pattern:18ea0c30-2d77-11e8-93f2-6f8a391f33ef
[00:09:38]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/Wsjh9CqpTP2Cgro6qEMQTA] update_mapping [_doc]
[00:09:38]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/Wsjh9CqpTP2Cgro6qEMQTA] update_mapping [_doc]
[00:09:38]               │ info Pointing alias .kibana to .kibana_2.
[00:09:38]               │ info Finished in 478ms.
[00:09:38]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:09:38]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1586958207549300701] [.kibana_2/Wsjh9CqpTP2Cgro6qEMQTA] update_mapping [_doc]
[00:09:39]               │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:39]               │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:39]               │ debg ... sleep(700) start
[00:09:39]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586959872665#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:39]               │
[00:09:39]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:40]               │ debg ... sleep(700) end
[00:09:40]               │ debg returned from get, calling refresh
[00:09:40]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586959872665#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:40]               │
[00:09:40]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:41]               │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:41]               │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:41]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:43]               │ debg TestSubjects.find(kibanaChrome)
[00:09:43]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:43]               │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 62:139970 "INFO: 2020-04-15T14:11:15Z
[00:09:43]               │        Adding connection to http://localhost:6161/elasticsearch
[00:09:43]               │
[00:09:43]               │      "
[00:09:43]               │ debg ... sleep(501) start
[00:09:44]               │ debg ... sleep(501) end
[00:09:44]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:44]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:09:44]               │ debg ... sleep(501) start
[00:09:45]               │ debg ... sleep(501) end
[00:09:45]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:45]               │ debg TestSubjects.exists(statusPageContainer)
[00:09:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:47]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:48]             └-: invalid scripted field error
[00:09:48]               └-> "before all" hook
[00:09:48]               └-> is rendered
[00:09:48]                 └-> "before each" hook: global before each
[00:09:48]                 │ debg TestSubjects.exists(discoverFetchError)
[00:09:48]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverFetchError"]') with timeout=2500
[00:09:50]                 │ debg --- retry.tryForTime error: [data-test-subj="discoverFetchError"] is not displayed
[00:09:51]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app errors invalid scripted field error is rendered.png"
[00:09:51]                 │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:51]                 │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app errors invalid scripted field error is rendered.html
[00:09:51]                 └- ✖ fail: "discover app errors invalid scripted field error is rendered"
[00:09:51]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/discover/_errors.js:41:40)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align label behavior of median aggregation with that of other single metrics aggregations
4 participants