Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align label behavior of median aggregation with that of other single metrics aggregations #18912

Closed
sophiec20 opened this issue May 8, 2018 · 1 comment · Fixed by #58521
Closed
Assignees
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@sophiec20
Copy link
Contributor

Kibana version: 6.3.0

Original install method (e.g. download page, yum, from source, etc.): zip

Describe the bug:
The visualisation custom label for median is applied differently to the custom labels for mean etc

Steps to reproduce:

  1. Create data table visualization
  2. For a numeric value, pick mean, min, max and median
  3. View results of visualization

Expected behavior:
The column heading for median is written as "50th percentile of median". I would have expected this to be written just as "median" which would be similar behavior to "mean".

Screenshots (if relevant):
image

Errors in browser console (if relevant):
None

Provide logs and/or server output (if relevant):
N/a

Any additional context:

@sophiec20 sophiec20 changed the title Custom label for median visualization is applied differently for median compared with mean Custom label for median is applied differently for median compared with mean May 8, 2018
@stacey-gammon stacey-gammon added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) triage_needed bug Fixes for quality problems that affect the customer experience labels May 8, 2018
@timroes timroes added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels May 9, 2018
@timroes
Copy link
Contributor

timroes commented May 9, 2018

Since the media is just the 50th percentile, we are using the percentiles aggregation with 50th percentile, but that means that also the percentile labels will be used, which always prefix the percentile to the actual label, since you could potentially have multiple percentiles specified. So I consider this to be expected behavior at the moment, and switched the label from bug to enhancement, since I would totally agree, that it might be nicer if we would actually behave the same as with Average and I would also like to by default just having the label Median of processing_time_ms instead of 50th percentile of processing_time_ms.

@timroes timroes changed the title Custom label for median is applied differently for median compared with mean Align label behavior of media aggregation with that of other single metrics aggregations May 9, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes timroes added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Oct 8, 2018
@wylieconlon wylieconlon changed the title Align label behavior of media aggregation with that of other single metrics aggregations Align label behavior of median aggregation with that of other single metrics aggregations Feb 25, 2020
@wylieconlon wylieconlon self-assigned this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
4 participants