Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Label broken on percentiles agg #6246

Closed
rashidkpc opened this issue Feb 13, 2016 · 13 comments
Closed

Custom Label broken on percentiles agg #6246

rashidkpc opened this issue Feb 13, 2016 · 13 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.0.0

Comments

@rashidkpc
Copy link
Contributor

The custom label option does not function on the percentiles agg

screen shot 2016-02-13 at 2 46 53 pm

@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience P1 labels Feb 13, 2016
@jakommo
Copy link
Contributor

jakommo commented Apr 8, 2016

Also broken on Median, not sure if it is related to this or should have it's own issue(?)
selection_140

@ycombinator ycombinator self-assigned this Apr 21, 2016
@ycombinator
Copy link
Contributor

ycombinator commented Apr 21, 2016

@rashidkpc @jakommo Where should the custom label go in the visualization? I'm assuming it should replace "percentile" but let me know if you expect to see something else happen.

@jakommo
Copy link
Contributor

jakommo commented Apr 22, 2016

@ycombinator I'd say it should be the field name. So in the above example it would replace request_size with the Custom label value test_median.

@ycombinator
Copy link
Contributor

Thanks @jakommo. I'll make it so.

ycombinator added a commit that referenced this issue Apr 28, 2016
Honor custom label, if set, in percentile and median metric visualizations
@ycombinator
Copy link
Contributor

Fixed by #7021

@jakommo
Copy link
Contributor

jakommo commented May 3, 2016

Thanks @ycombinator

@tbragin tbragin added the v5.0.0 label Oct 10, 2016
@shaharmor
Copy link
Contributor

Does this also fixes it for Pie charts?

@palmerabollo
Copy link

palmerabollo commented Dec 8, 2016

I think it's still broken in Kibana 5.x. The "median" aggregation still shows "50th percentile of varname" instead of the custom label (checked in Kibana 5.0.2).

@asawariS
Copy link

Looks like still broken in 6.0.0-rc1. Happens with both metrics and arc/circle.

@Marauderrr
Copy link

Still broken in 6.5.4

@dershodan
Copy link

Still broken in 7.0.0

@palmerabollo
Copy link

@ycombinator could you please reopen the issue?

@ycombinator ycombinator removed their assignment Apr 29, 2019
@ycombinator ycombinator reopened this Apr 29, 2019
@ycombinator ycombinator added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Apr 29, 2019
@wylieconlon
Copy link
Contributor

There are two issues described here. The issue originally described was fixed by @ycombinator, and I am about to merge a fix for the Median labeling issue (which was tracked separately). The median labeling fix is here #58521

Given that the original issue here is fixed, I am closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.0.0
Projects
None yet
Development

No branches or pull requests

10 participants