Honor custom label, if set, in percentile and median metric visualizations #7021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| })); | ||
|
|
||
| it('uses the custom label if it is set', function () { | ||
| let vis = new Vis(indexPattern, {}); |
There was a problem hiding this comment.
We should use const instead of let wherever possible, which is in most places. The only variables in this file that need let are the three at the top of the initial describe.
There was a problem hiding this comment.
Good catch. Fixing this and others in this file as well. Thanks!
|
This should probably be applied to "percentile ranks" as well. But rather than block this PR further, why don't we get this thing merged so it can go out with alpha2 and then address percentile ranks as a follow up PR? |
|
LGTM |
|
@ycombinator Do you think this is backportable to 4.6? |
|
@ycombinator can you backport this fix to 4.6? |
ycombinator
added a commit
that referenced
this pull request
Oct 10, 2016
--------- **Commit 1:** Honor custom label, if set, in percentile and median metric visualizations * Original sha: 4680853 * Authored by Shaunak Kashyap <[email protected]> on 2016-04-22T02:15:31Z **Commit 2:** Using custom label to replace field name * Original sha: b0e8d7c * Authored by Shaunak Kashyap <[email protected]> on 2016-04-22T19:00:23Z **Commit 3:** Using consts instead of lets * Original sha: 7534b38 * Authored by Shaunak Kashyap <[email protected]> on 2016-04-27T18:42:24Z
ycombinator
added a commit
that referenced
this pull request
Oct 10, 2016
[backport] PR #7021 to 4.6 - Honor custom label, if set, in percentile and median metric visualizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6246