Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded EUI to 18.0.0 #54042

Merged
merged 13 commits into from
Jan 14, 2020
Merged

Upgraded EUI to 18.0.0 #54042

merged 13 commits into from
Jan 14, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

18.0.0

  • Converted EuiFieldText to Typescript (#2688)
  • Added nested glyph to EuiIcon (#2707)
  • Added tableLayout prop to EuiTable, EuiBasicTable and EuiInMemoryTable to provide the option of auto layout (#2697)
  • Converted EuiSuggest to Typescript (#2692)
  • Converted EuiErrorBoundary to Typescript (#2690)
  • Updated EuiNavDrawer to accept React fragments (#2710)
  • Added EuiFormFieldset and EuiFormLegend components (#2706)
  • Adjusted colors of color blind viz palette (#2686)
  • Converted EuiSelect to Typescript (#2694)
  • Added aggregate, pageSelect, pagesSelect, securitySignal, securitySignalDetected, securitySignalResolved and timeline icons (#2704)
  • Added useDependentState custom hook (#2725)
  • Added isClearable prop to EuiFieldSearch (#2723)

Bug fixes

  • Fixed isExpanded property of nodes from EuiTreeView (#2700)
  • Added text selection to EuiLink button (#2722)
  • Fixed bug in EuiDataGrid where resizing columns changed the active DOM element (#2724)
  • Fixed position of scrollbar in EuiCodeBlock (#2727)
  • Fixed bug in EuiDataGrid that prevented the "Hide fields" popover from showing an updated column list (#2725)

Breaking changes

  • Changed accepted properties of the color_palette method to accept an array of colors (#2686)
  • Removed the palette export to export each palette function directly (#2686)
  • Changed the palette functions to be methods that accept a number of steps and removed .colors key (#2686)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 6, 2020
@chandlerprall chandlerprall mentioned this pull request Jan 7, 2020
Closed
@Bargs Bargs mentioned this pull request Jan 7, 2020
Merged
3 tasks
@chandlerprall
Copy link
Contributor Author

jenkins test this

@chandlerprall
Copy link
Contributor Author

jenkins test this

@cchaos
Copy link
Contributor

cchaos commented Jan 11, 2020

@kibanamachine merge upstream

@cchaos
Copy link
Contributor

cchaos commented Jan 11, 2020

@elasticmachine merge upstream

@cchaos
Copy link
Contributor

cchaos commented Jan 11, 2020

FYI this is what I get locally on initial load
Screen Shot 2020-01-11 at 12 30 25 PM

@chandlerprall chandlerprall changed the title [WIP] Upgraded EUI to 18.0.0 Upgraded EUI to 18.0.0 Jan 13, 2020
@chandlerprall chandlerprall marked this pull request as ready for review January 13, 2020 05:19
@chandlerprall chandlerprall requested a review from a team as a code owner January 13, 2020 05:19
@chandlerprall chandlerprall requested a review from a team January 13, 2020 05:19
@chandlerprall chandlerprall requested review from a team as code owners January 13, 2020 05:19
@chandlerprall chandlerprall requested review from a team as code owners January 13, 2020 05:19
dgieselaar
dgieselaar reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit re type safety in APM code, other than that looks good. I've assigned this to @formgeist for a design sign-off as the colors have been changed.

x-pack/legacy/plugins/apm/public/components/shared/SelectWithPlaceholder/index.tsx Outdated Show resolved Hide resolved
@dgieselaar dgieselaar requested a review from formgeist January 13, 2020 09:12
lizozom
lizozom approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't checkout.
Overall @elastic/kibana-app-arch changes LGTM (mostly snapshots).
Added a question about the prepend type definition.

src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx Outdated Show resolved Hide resolved
@legrego legrego self-requested a review January 13, 2020 12:52
legrego
legrego approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese
nreese approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review, tested in chrome

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for ML LGTM

@chandlerprall chandlerprall merged commit 6bed80b into elastic:master Jan 14, 2020
@chandlerprall chandlerprall deleted the eui-18.0.0 branch January 14, 2020 18:27
@Bamieh Bamieh mentioned this pull request Jan 14, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Jan 14, 2020
Merged
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@chandlerprall @cchaos
@elasticmachine @jkelastic
Upgraded EUI to 18.0.0 (elastic#54042)
b8717d8 
* Upgraded EUI to 18.0.0

* Fix breaks from `palette._.colors` changes

* snapshots

* Updated hard coded hex color codes in tests, fixed TS errors

* Updated a functional test's selector; added (BSD-3-Clause AND Apache-2.0) to license checker whitelist

* Functional test selector update

* Updated vega browser-ci tests for palette changes

* rebased on master

* One more location for EUI package number update and yarn lock

* Fixed lurking [but introduced] TypeScript logic bug

* Swap a prop definition for the same value but tied closer to its source

Co-authored-by: Caroline Horn <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@myasonik myasonik myasonik approved these changes

@formgeist formgeist formgeist approved these changes

@legrego legrego legrego approved these changes

@lizozom lizozom lizozom approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.