Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiFieldText: converted to Typescript #2688

Merged
merged 7 commits into from
Dec 30, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Dec 18, 2019

Summary

Closes #2648

Converted EuiFieldText to Typescript.

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ffknob
Copy link
Contributor Author

ffknob commented Dec 18, 2019

Just one thing: I had to deal with ./components/color_picker/color_picker.tsx:346:17 trying to pass a ReactChild to the aria-label property (see error below). I really don't know if my fix is the way to go or no...

src/components/color_picker/color_picker.tsx:346:17 - error TS2322: Type 'ReactChild' is not assignable to type 'string | undefined'.
  Type 'number' is not assignable to type 'string | undefined'.

346                 aria-label={isColorSelectorShown ? openLabel : closeLabel}

@chandlerprall chandlerprall self-requested a review December 19, 2019 18:42
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs:

src/components/form/field_text/field_text.tsx Outdated Show resolved Hide resolved
src/components/form/field_text/field_text.tsx Outdated Show resolved Hide resolved
src/components/form/field_text/field_text.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lastly, needs to touch a couple more files,

then this should be good to go

@ffknob
Copy link
Contributor Author

ffknob commented Dec 27, 2019

Had to commit skiping pre-commit hook. Couldn't find a way to get pass this error (don't know where it came from, since I just commited without any problems):

pre-commit: 
pre-commit: We've failed to pass the specified git pre-commit hooks as the `test-staged`
pre-commit: hook returned an exit code (1). If you're feeling adventurous you can
pre-commit: skip the git pre-commit hooks by adding the following flags to your commit:
pre-commit: 
pre-commit:   git commit -n (or --no-verify)
pre-commit: 
pre-commit: This is ill-advised since the commit is broken.
pre-commit: 

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, pulled & tested locally

@chandlerprall
Copy link
Contributor

jenkins test this

@chandlerprall
Copy link
Contributor

Had to commit skiping pre-commit hook. Couldn't find a way to get pass this error (don't know where it came from, since I just commited without any problems):

Hmm, interesting. I checked out your branch out and don't see any issues (CI passed as well). If you continue getting this on other branches please bring it up again.

@chandlerprall chandlerprall merged commit 01a6c3f into elastic:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFieldText needs to be converted to TS
4 participants