-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiFieldText: converted to Typescript #2688
EuiFieldText: converted to Typescript #2688
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Just one thing: I had to deal with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs:
- remove src/components/form/field_text/index.d.ts
- remove reference at
eui/src/components/form/index.d.ts
Line 5 in 705de53
/// <reference path="./field_text/index.d.ts" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, needs to touch a couple more files,
- remove src/components/form/field_text/index.d.ts
- remove reference at
eui/src/components/form/index.d.ts
Line 5 in 705de53
/// <reference path="./field_text/index.d.ts" />
then this should be good to go
Had to commit skiping
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, pulled & tested locally
jenkins test this |
Hmm, interesting. I checked out your branch out and don't see any issues (CI passed as well). If you continue getting this on other branches please bring it up again. |
Summary
Closes #2648
Converted
EuiFieldText
to Typescript.Checklist