-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiSelect: converted to Typescript #2694
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Looks like there is no |
Disabling the element will exclude it from inclusion in POSTs, which would be a breaking change. There's another option presented in https://stackoverflow.com/a/23428851 , @cchaos thoughts on the design side here? |
My thoughts are that allowing for Therefor |
@ffknob please go ahead and remove the |
Removed the prop and related tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the last one
|
||
import { EuiFormControlLayout } from '../form_control_layout'; | ||
interface Option extends OptionHTMLAttributes<HTMLOptionElement> { | ||
text: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text: string; | |
text: React.ReactNode; |
jenkins test this |
Summary
Closes #2655
Converted
EuiSelect
to Typescript.Checklist