Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert hiding Kibana icon, test Percy rendering #43990

Merged
merged 23 commits into from
Sep 19, 2019
Merged

Revert hiding Kibana icon, test Percy rendering #43990

merged 23 commits into from
Sep 19, 2019

Conversation

liza-mae
Copy link
Contributor

Revert hiding Kibana icon, test Percy rendering.

@liza-mae liza-mae requested a review from a team as a code owner August 26, 2019 14:17
@liza-mae liza-mae added the release_note:skip Skip the PR/issue when compiling release notes label Aug 26, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

1 similar comment
@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae requested a review from a team as a code owner August 26, 2019 18:10
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

spalger
spalger reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request review if needed later

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

@elasticmachine update branch

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

Note, visual testing is currently disabled on master, so before merging this PR, I will disable them also.

spalger
spalger approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we aren't changing the percy key, or enabling visualRegression tests on master until we have enough data to be confident that they aren't flaky anymore.

@liza-mae
Copy link
Contributor Author

Yes, thanks I will revert the changes to the Percy key and will disable the visual tests before merging.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

Jest tests passed, the failure is on
Chrome UI Functional Tests.test/functional/apps/visualize/_tsvb_markdown·ts.visualize app visual builder markdown should allow printing raw value of data (from (TEST-kibana-ciGroup6-Chrome UI Functional Tests.xml))
Error: expected '{{ count.data.raw.[0].[1] }}}}' to equal '6'
at Assertion.assert (packages/kbn-expect/expect.js:100:11)
at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:221:8)
at Assertion.(anonymous function) [as be] (packages/kbn-expect/expect.js:69:22)
at Context.be (test/functional/apps/visualize/_tsvb_markdown.ts:67:25)
at process._tickCallback (internal/process/next_tick.js:68:7)

Looks like this test has been skipped on master.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae merged commit 4c75b55 into elastic:master Sep 19, 2019
@liza-mae liza-mae deleted the liza/test-percy-rendering branch September 19, 2019 17:23
This was referenced Sep 19, 2019
Merged
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Sep 19, 2019
@liza-mae
Revert hiding Kibana icon, test Percy rendering (elastic#43990)
5f2bc63 
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
liza-mae added a commit to liza-mae/kibana that referenced this pull request Sep 19, 2019
@liza-mae
Revert hiding Kibana icon, test Percy rendering (elastic#43990)
b169bcf 
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
liza-mae added a commit that referenced this pull request Sep 19, 2019
@liza-mae
Revert hiding Kibana icon, test Percy rendering (#43990) (#46168)
e666447 
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
liza-mae added a commit that referenced this pull request Sep 19, 2019
@liza-mae
Revert hiding Kibana icon, test Percy rendering (#43990) (#46169)
d2687ea 
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
@liza-mae liza-mae mentioned this pull request Sep 21, 2019
Merged
3 tasks
@liza-mae liza-mae mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@liza-mae liza-mae

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liza-mae @elasticmachine @spalger