Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hiding Kibana icon, test Percy rendering #43990

Merged
merged 23 commits into from
Sep 19, 2019
Merged

Revert hiding Kibana icon, test Percy rendering #43990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5601d0d
Revert hiding Kibana icon, test Percy rendering
Aug 26, 2019
f332d58
Update jobs.yml
liza-mae Aug 26, 2019
8b771b7
Use percy token for kibana dev
Aug 26, 2019
c178193
Update Percy token to read from kibana-issues
liza-mae Aug 26, 2019
6a323b6
Read correct field
liza-mae Aug 26, 2019
d2d890b
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 9, 2019
d2bafa7
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 12, 2019
ba6b6a4
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 12, 2019
167ccc4
increase timeout
Sep 12, 2019
d51a772
Merge branch 'liza/test-percy-rendering' of github.com:liza-mae/kiban…
Sep 12, 2019
48ebea4
Run each visual job 10 times
Sep 13, 2019
6a42563
Revert last commit
Sep 13, 2019
d5c47f0
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 16, 2019
cd61e6f
Increase timeout
Sep 17, 2019
4b0af95
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 17, 2019
8354ef7
Merge branch 'liza/test-percy-rendering' of github.com:liza-mae/kiban…
Sep 17, 2019
ca07ba4
Disable visual tests and revert percy token
Sep 17, 2019
31f10c0
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 17, 2019
88bcfcd
Fix jest tests
Sep 18, 2019
d809110
Merge branch 'liza/test-percy-rendering' of github.com:liza-mae/kiban…
Sep 18, 2019
988197f
Another jest test fix
Sep 18, 2019
cbdfa2d
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 18, 2019
f161df2
Merge branch 'master' of github.com:elastic/kibana into liza/test-per…
Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/legacy/ui/public/exit_full_screen/__snapshots__/exit_full_screen_button.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions ..._react/public/exit_full_screen_button/__snapshots__/exit_full_screen_button.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/plugins/kibana_react/public/exit_full_screen_button/exit_full_screen_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ExitFullScreenButtonUi extends PureComponent<Props> {

public render() {
return (
<div className="hideInPercy">
<div>
<EuiScreenReaderOnly>
<p aria-live="polite">
{i18n.translate('kibana-react.exitFullScreenButton.fullScreenModeDescription', {
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/jenkins_visual_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fi
export TEST_BROWSER_HEADLESS=1

checks-reporter-with-killswitch "Kibana visual regression tests" \
yarn run percy exec \
yarn run percy exec -t 500 \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$installDir" \
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/jenkins_xpack_visual_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export TEST_BROWSER_HEADLESS=1
cd "$XPACK_DIR"

checks-reporter-with-killswitch "X-Pack visual regression tests" \
yarn run percy exec \
yarn run percy exec -t 500 \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$KIBANA_INSTALL_DIR" \
Expand Down