Skip to content

Commit

Permalink
Revert hiding Kibana icon, test Percy rendering (elastic#43990)
Browse files Browse the repository at this point in the history
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
  • Loading branch information
liza-mae authored and Liza Dayoub committed Sep 19, 2019
1 parent a2f81e0 commit 5f2bc63
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 9 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ExitFullScreenButtonUi extends PureComponent<Props> {

public render() {
return (
<div className="hideInPercy">
<div>
<EuiScreenReaderOnly>
<p aria-live="polite">
{i18n.translate('kibana-react.exitFullScreenButton.fullScreenModeDescription', {
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/jenkins_visual_regression.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fi
export TEST_BROWSER_HEADLESS=1

checks-reporter-with-killswitch "Kibana visual regression tests" \
yarn run percy exec \
yarn run percy exec -t 500 \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$installDir" \
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/jenkins_xpack_visual_regression.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export TEST_BROWSER_HEADLESS=1
cd "$XPACK_DIR"

checks-reporter-with-killswitch "X-Pack visual regression tests" \
yarn run percy exec \
yarn run percy exec -t 500 \
node scripts/functional_tests \
--debug --bail \
--kibana-install-dir "$KIBANA_INSTALL_DIR" \
Expand Down

0 comments on commit 5f2bc63

Please sign in to comment.