[ML] Migrates single metric viewer to React. #41739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
refactoring
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui |
💔 Build Failed |
walterra
changed the title
walterra
force-pushed
the
ml-migrate-timeseriesviewer-react
branch
from
457c1b5 to
d9b6dec
Compare
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
|
Code LGTM but I'd like to give it a final test and take a look at the latest commits on Monday. No need to wait if you get the other two green checks, though. |
…meseriesviewer-react
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
|
@peteharverson fixed the display of entity counts:
|
💚 Build Succeeded |
peteharverson
approved these changes
Jul 29, 2019
alvarezmelissa87
approved these changes
Jul 29, 2019
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 29, 2019
Migrates the overall page of Single Metric Viewer to React.
88 tasks
walterra
added a commit
that referenced
this pull request
Jul 29, 2019
7 tasks
This was referenced Sep 4, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18374.
Migrates the overall page of Single Metric Viewer to React.
timeseriesexplorer_controller.jsandtimeseriesexplorer.htmltimeseriesexplorer_route.jstimeseriescontroller_directive.js.Please keep the following in mind when reviewing this: A lot of the lines that show up as new in the diffs are methods moved from angular scope to react state. The main goal was to make this migration work and I did not put an emphasis on updating every single line of code to the newest and shiniest type of code we've adopted since the original single metric viewer was created. The aim of this PR is a strict focus to migrate from angularjs to React with minimal risk of regressions. That's why the existing React code was not changed to e.g. use hooks, TypeScript or remove some other bits we consider legacy (e.g. lodash). Nonetheless I'm thankful for any suggestions for future improvements!
Todos:
*exports 04f2d4aChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers