Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.8] [ML] Fix to automatically apply refresh settings set in URL #47052

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Oct 1, 2019

Summary

Fix to check and apply auto-refresh settings from the URL when opening the Single Metric Viewer or Anomaly Explorer.

Previously if the URL contained settings such as refreshInterval:(pause:!f,value:5000),time:(from:now-30m,mode:quick,to:now), the time picker auto-refresh control would be set correctly at the top of the view, but auto-refresh would not actually be running on the page.

Note in 7.x, this has been fixed for 7.4 by the refactor of the pages to React in #41739.

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 93d974a into elastic:6.8 Oct 2, 2019
@peteharverson peteharverson deleted the ml-autorefresh-68 branch October 2, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants