Remove ts-loader from canvas storybook webpack config. #33896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
spalger
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
LGTM, but let's make sure @clintandrewhall is good with it before merging
💚 Build Succeeded |
|
Should be fine... I'll ensure any backported PRs include this change. |
clintandrewhall
approved these changes
Mar 27, 2019
|
I just tested this change, and it doesn't work... because |
clintandrewhall
requested changes
Mar 27, 2019
|
|
clintandrewhall
approved these changes
Mar 27, 2019
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
spalger
reviewed
Mar 28, 2019
mistic
changed the title
clintandrewhall
added a commit
that referenced
this pull request
Apr 2, 2019
## Summary (Fixes #33734 #33757 #33735) This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection. It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently. This PR also includes + modifies #33896 and updates Storybook to v5. 
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Apr 2, 2019
(Fixes elastic#33734 elastic#33757 elastic#33735) This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection. It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently. This PR also includes + modifies elastic#33896 and updates Storybook to v5. 
mistic
added
the
non-issue
timroes
added
the
release_note:skip
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow up for #33093 as I realised that I've missed the
ts-loaderusage in that particular file. All the typescript code should be loaded usingbabel-loaderright now. I'm just tagging this for8.0.0as it looks like that file doesn't exist for7.x.