Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Canvas page background breaks color selection #33734

Closed
rashidkpc opened this issue Mar 22, 2019 · 1 comment · Fixed by #34075
Closed

Invalid Canvas page background breaks color selection #33734

rashidkpc opened this issue Mar 22, 2019 · 1 comment · Fixed by #34075
Assignees
@clintandrewhall
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@rashidkpc
Copy link
Contributor

Kibana version:
Master

Steps to reproduce:

  1. Open page background color dialog
  2. Set background color to "broken"
  3. Click off of background color select
  4. Note that background color selector is gone, and you can't get it back

broken_background
@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 added the loe:small Small Level of Effort label Mar 22, 2019
@clintandrewhall clintandrewhall mentioned this issue Mar 28, 2019
Merged
clintandrewhall added a commit that referenced this issue Apr 2, 2019
@clintandrewhall
[canvas] Color fixes + Storybook 5 (#34075)
365fd4b 
## Summary

(Fixes #33734 #33757 #33735)

This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection.  It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently.

This PR also includes + modifies #33896 and updates Storybook to v5.

![Mar-28-2019 09-18-45](https://user-images.githubusercontent.com/297604/55168267-873a1c00-5140-11e9-93b9-f5ca86e70098.gif)
clintandrewhall added a commit to clintandrewhall/kibana that referenced this issue Apr 2, 2019
@clintandrewhall
[canvas] Color fixes + Storybook 5 (elastic#34075)
8e63d9f 
(Fixes elastic#33734 elastic#33757 elastic#33735)

This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection.  It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently.

This PR also includes + modifies elastic#33896 and updates Storybook to v5.

![Mar-28-2019 09-18-45](https://user-images.githubusercontent.com/297604/55168267-873a1c00-5140-11e9-93b9-f5ca86e70098.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clintandrewhall clintandrewhall

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[canvas] Color fixes + Storybook 5 clintandrewhall/kibana
5 participants
@clintandrewhall @rashidkpc @cqliu1 @marius-dr @elasticmachine