Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Missing color pickers in container style #33757

Closed
cqliu1 opened this issue Mar 22, 2019 · 1 comment
Closed

[Canvas] Missing color pickers in container style #33757

cqliu1 opened this issue Mar 22, 2019 · 1 comment
Assignees
@clintandrewhall
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Mar 22, 2019

Kibana version:
master (current 71b1123)

Describe the bug:
The color pickers are missing from container style for the element background color and the border color.

Steps to reproduce:

  1. Add an element
  2. Add container style under Element style in the sidebar.
  3. Observe missing color pickers

Screenshots (if relevant):
Screenshot of container style on 6.7
Screen Shot 2019-03-22 at 4 47 40 PM

screenshot of container style on master
Screen Shot 2019-03-22 at 4 43 04 PM
@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort labels Mar 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 changed the title [Canvas] Missing color picker in container style [Canvas] Missing color pickers in container style Mar 22, 2019
@clintandrewhall clintandrewhall mentioned this issue Mar 28, 2019
Merged
clintandrewhall added a commit that referenced this issue Apr 2, 2019
@clintandrewhall
[canvas] Color fixes + Storybook 5 (#34075)
365fd4b 
## Summary

(Fixes #33734 #33757 #33735)

This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection.  It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently.

This PR also includes + modifies #33896 and updates Storybook to v5.

![Mar-28-2019 09-18-45](https://user-images.githubusercontent.com/297604/55168267-873a1c00-5140-11e9-93b9-f5ca86e70098.gif)
clintandrewhall added a commit to clintandrewhall/kibana that referenced this issue Apr 2, 2019
@clintandrewhall
[canvas] Color fixes + Storybook 5 (elastic#34075)
8e63d9f 
(Fixes elastic#33734 elastic#33757 elastic#33735)

This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection.  It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently.

This PR also includes + modifies elastic#33896 and updates Storybook to v5.

![Mar-28-2019 09-18-45](https://user-images.githubusercontent.com/297604/55168267-873a1c00-5140-11e9-93b9-f5ca86e70098.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clintandrewhall clintandrewhall

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintandrewhall @cqliu1 @marius-dr @elasticmachine