[ML] Ensure Anomaly Explorer filter retained on swimlane click #33131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
enhancement
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
11 tasks
💔 Build Failed |
💚 Build Succeeded |
peteharverson
approved these changes
Mar 13, 2019
| @@ -16,7 +16,6 @@ import { EuiEmptyPrompt } from '@elastic/eui'; | |||
|
|
|||
| export const ExplorerNoInfluencersFound = ({ swimlaneViewByFieldName, showFilterMessage = false }) => ( | |||
| <EuiEmptyPrompt | |||
| iconType="alert" | |||
There was a problem hiding this comment.
Not specifically related to this PR, but in the case where there are no influencers returned for the selected time and filter, but there are influencer results for the job, I wonder if we should change the warning text to something like No <fieldname> influencers found matching filter?
💚 Build Succeeded |
peteharverson
approved these changes
Mar 14, 2019
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Mar 14, 2019
…ic#33131) * Remove noInfluencers warning icon. Fix clickOutside console warning * retain filter on overall swimlane cell click * update euiLightTheme var names to fix suggestion style * update tests * update noInfluencers component snapshot * Show no influencers filter message if filter active
alvarezmelissa87
added a commit
that referenced
this pull request
Mar 14, 2019
… (#33239) * Remove noInfluencers warning icon. Fix clickOutside console warning * retain filter on overall swimlane cell click * update euiLightTheme var names to fix suggestion style * update tests * update noInfluencers component snapshot * Show no influencers filter message if filter active
alvarezmelissa87
added
the
non-issue
alvarezmelissa87
removed
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes the following follow up tasks detailed in #32505
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately