Upgrades EUI to 9.x #32009

jasonrhodes · 2019-02-26T13:01:40Z

Summary

This PR replaces #31935 and #31801

UPDATE: The latest EUI is now at 9.x, so this PR upgrades to 9.0.x

jasonrhodes · 2019-02-26T13:03:22Z

x-pack/plugins/apm/public/components/app/Main/__test__/__snapshots__/Home.test.js.snap

@@ -31,9 +31,7 @@ exports[`Home component should render 1`] = `
      <SetupInstructionsLink />
    </EuiFlexItem>
  </EuiFlexGroup>
-  <EuiSpacer


@chandlerprall see comments from @sqren and @nreese here: #31935 (comment)

Has the default size for this component changed?

Default size remains the same, but has been moved from defaultProps to being applied at destructuring in the function component's signature, so React is not aware of the default.

elasticmachine · 2019-02-26T13:22:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-26T18:29:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese · 2019-03-01T13:13:12Z

Have you seen #32291? Looks like there is another PR attempting to bump EUI to 9.0.1

jasonrhodes · 2019-03-01T13:19:46Z

@chandlerprall @thompsongl I've removed all of the infra duplicates and it seems like the only error left has to do with some EuiProgress component wrapped in a styled-components wrapper here: x-pack/plugins/infra/public/components/logging/log_text_stream/loading_item_view.tsx

ping @skh @elastic/infrastructure-ui

azasypkin · 2019-03-01T13:28:31Z

@maryia-lapata @jasonrhodes Whoever drags this over a finish line, please don't forget to create follow-up PR to cover #31480 (comment) (this time it'd be better to have a separate follow-up so that we can easily backport a part of it to 6.7 and 7.0 as well). It's something that should always come with EUI upgrades now.

I'm not sure if we have "tokens changelog" section in the main EUI change logs already, but if not we should rely on https://elastic.github.io/eui/#/package/i18n-tokens for this particular upgrade.

Feel free to reach out if you have any questions.

elasticmachine · 2019-03-01T13:30:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chandlerprall · 2019-03-01T15:03:04Z

I'm not sure if we have "tokens changelog" section in the main EUI change logs already

Not yet

jasonrhodes · 2019-03-01T21:43:05Z

Update: I've read through styled-components docs and have thus far not been able to figure out how to get around the problem mentioned here: #32009 (comment)

We may need to use // @ts-ignore and let the infra team work with the EUI team to circle back on this.

elasticmachine · 2019-03-01T22:06:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-01T23:21:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jasonrhodes · 2019-03-01T23:31:57Z

Now we're getting snapshot failures, which probably explains why the other 9.x PR had about 40-50 more file changes than this one. Heading out for the weekend, will check back on what's going on Monday.

jasonrhodes · 2019-03-04T14:03:38Z

I've updated snapshots. Here are the main updates:

rgb colors become hex
labelType=label is added to EuiFormRow (default changed?)
everything that asserts on the results of the status() function in this file (plugins/index_management/jest/components/index_table.test.js) has "status" prepended to the resulting snapshotted text
- "clearing cache..." becomes "statusclearing cache..."
- "open" becomes "statusopen"
- etc
<EuiFlyoutHeader> -- hasBorder={false} disappears (default changed?)
<EuiTableRowCell> gains new mobileOptions.show = true prop
<td data-header="X"> is replaced with <div class="euiTableRowCell__mobileHeader euiTableRowCell--hideForDesktop">X</div> (e.g. plugins/remote_clusters/public/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.test.js)
form row labels are now enclosed in divs (e.g. plugins/remote_clusters/public/sections/components/remote_cluster_form/remote_cluster_form.test.js)
giant svg diff here: plugins/apm/public/components/app/ErrorGroupOverview/List/test/List.test.tsx
EuiProgress no longer specifies position: static (plugins/apm/public/components/shared/ImpactBar/test/ImpactBar.test.js)

jasonrhodes · 2019-03-04T14:24:28Z

There are a few failing tests in x-pack, that I didn't feel comfortable updating. It seems like the EuiInMemoryTable is preprending "Field" to the field items? Not sure.

 FAIL  plugins/rollup/public/crud_app/sections/job_list/detail_panel/detail_panel.test.js (6.138s)
  ● <DetailPanel /> › job detail › terms tab content › should list the Job terms fields

    expect(received).toEqual(expected)

    Difference:

    - Expected
    + Received

      Array [
    -   "Dest",
    -   "Carrier",
    -   "DestCountry",
    +   "FieldDest",
    +   "FieldCarrier",
    +   "FieldDestCountry",
      ]

elasticmachine · 2019-03-04T14:46:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chandlerprall · 2019-03-04T15:30:19Z

Checked on a few of Jason's noted changes to be safe -

labelType=label is added to EuiFormRow (default changed?)

labelType is a new prop, label is the default value (and mimics the old, prop-less behaviour)

everything that asserts on the results of the status() function in this file (plugins/index_management/jest/components/index_table.test.js) has "status" prepended to the resulting snapshotted text

status is added in a always-present-but-CSS-hidden-on-desktop div, the snapshot is picking up this extra text

-- hasBorder={false} disappears (default changed?)

EuiFlyoutHeader was converted to TypeScript, where we remove defaultProps in favor of adding destructing defaults. The value is the same, but not exposed directly to React now.

EuiProgress no longer specifies position: static

Same as EuiFlyoutHeader, component was converted to TS and React no longer sees the defaults (position default is still static)

chandlerprall · 2019-03-04T16:01:04Z

The detail_panel.test.js difference is the same thing that happened for index_table.test.js and its status text - there is a mobile-only div saying Field - the snapshot is fine to update.

chandlerprall · 2019-03-04T16:29:24Z

I have a commit (chandlerprall@2ea1362) that fixes the test. Seems I can't push to Jason's branch, nor make a PR against his branch (?)

… rendered values

elasticmachine · 2019-03-06T19:40:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chandlerprall · 2019-03-06T20:07:40Z

jenkins test this

elasticmachine · 2019-03-06T20:59:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-06T21:32:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chandlerprall

LGREATTM

walterra

ML related changes LGTM.

* Fixed a simple argument bug and removed infra date picker EUI types * Fixes for EUI date picker types * eui_8.0.0 * fix type errors in query_bar * Small changes for EUI types * Updates EUI to 9.0.0 and removes @types/react-datepicker as it now ships with EUI * Updates to EUI 9.0.1 and removes duplicate types in infra eui.d.ts * ts-ignore applied to ongoing type error with styled components and EUI * Changes EuiProgress props to avoid TS errors * Updates EUI 9.0 snapshots * Updates kibana root snapshots for EUI 9.0 upgrade * Update detail_panel.test.js for EUI changes * Updated functioanl and unit tests to properly inspect EuiTableRowCell rendered values * Fix docs_level_security_roles.js func tests * Update EUI to 9.0.2 * Fixed failing snapshot for EUI icon default prop

…ic#33152) This fixes a problem introduced with elastic#32009, in which the meaning of the `isLoading` property for the `<ProgressEntry>` component was inverted.

This fixes a problem introduced with #32009, in which the meaning of the `isLoading` property for the `<ProgressEntry>` component was inverted.

jasonrhodes mentioned this pull request Feb 26, 2019

eui_8.0.0 #31935

Closed

jasonrhodes commented Feb 26, 2019

View reviewed changes

jasonrhodes mentioned this pull request Feb 26, 2019

Preparation for upgrading EUI so that it includes date picker types #31801

Closed

skh mentioned this pull request Feb 26, 2019

[Infra UI] datetime range picker and autorefresh button overlap in IE 11 #27196

Closed

nreese mentioned this pull request Feb 26, 2019

[Input controls vis] replace react-input-range with EuiDualRange #31119

Merged

jasonrhodes force-pushed the eui-upgrade-8.x branch from dbbd646 to 1a08a78 Compare March 1, 2019 13:14

jasonrhodes changed the title ~~Upgrades EUI to 8.x~~ Upgrades EUI to 9.x Mar 1, 2019

jasonrhodes mentioned this pull request Mar 1, 2019

Upgrade EUI to 9.0.1 #32291

Closed

7 tasks

jasonrhodes marked this pull request as ready for review March 1, 2019 13:18

jasonrhodes requested review from a team as code owners March 1, 2019 13:18

maryia-lapata mentioned this pull request Mar 4, 2019

[Vis: Default editor] EUIficate agg-select #31892

Merged

3 tasks

jasonrhodes and others added 7 commits March 6, 2019 13:54

Changes EuiProgress props to avoid TS errors

e814e05

Updates EUI 9.0 snapshots

98c837a

Updates kibana root snapshots for EUI 9.0 upgrade

6ffd854

Update detail_panel.test.js for EUI changes

397ae69

Updated functioanl and unit tests to properly inspect EuiTableRowCell…

525af6d

… rendered values

Fix docs_level_security_roles.js func tests

7886e15

Update EUI to 9.0.2

5ae2259

jasonrhodes force-pushed the eui-upgrade-8.x branch from d88e311 to 5ae2259 Compare March 6, 2019 18:54

Fixed failing snapshot for EUI icon default prop

5b3cff0

chandlerprall approved these changes Mar 6, 2019

View reviewed changes

kobelb approved these changes Mar 6, 2019

View reviewed changes

jasonrhodes added v7.2.0 v8.0.0 labels Mar 6, 2019

ogupte approved these changes Mar 6, 2019

View reviewed changes

walterra approved these changes Mar 7, 2019

View reviewed changes

jasonrhodes merged commit ae754ac into elastic:master Mar 7, 2019

jasonrhodes deleted the eui-upgrade-8.x branch March 7, 2019 12:03

jasonrhodes mentioned this pull request Mar 7, 2019

[7.x] Upgrades EUI to 9.x (#32009) #32642

Merged

alvarezmelissa87 mentioned this pull request Mar 7, 2019

[ML] Anomaly Explorer Filtering follow-up tasks #32505

Closed

11 tasks

cjcenizal mentioned this pull request Mar 12, 2019

Fix 'Create Rollup Index Pattern' button badge color error #32954

Merged

alvarezmelissa87 mentioned this pull request Mar 13, 2019

[ML] Ensure Anomaly Explorer filter retained on swimlane click #33131

Merged

3 tasks

weltenwort mentioned this pull request Mar 13, 2019

[Logs UI] Revert unintended inversion of loading state meaning #33152

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades EUI to 9.x #32009

Upgrades EUI to 9.x #32009

jasonrhodes commented Feb 26, 2019 •

edited

Loading

jasonrhodes Feb 26, 2019

chandlerprall Feb 26, 2019

elasticmachine commented Feb 26, 2019

elasticmachine commented Feb 26, 2019

nreese commented Mar 1, 2019

jasonrhodes commented Mar 1, 2019

azasypkin commented Mar 1, 2019 •

edited

Loading

elasticmachine commented Mar 1, 2019

chandlerprall commented Mar 1, 2019

jasonrhodes commented Mar 1, 2019

elasticmachine commented Mar 1, 2019

elasticmachine commented Mar 1, 2019

jasonrhodes commented Mar 1, 2019

jasonrhodes commented Mar 4, 2019 •

edited

Loading

jasonrhodes commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

chandlerprall commented Mar 4, 2019

chandlerprall commented Mar 4, 2019 •

edited

Loading

chandlerprall commented Mar 4, 2019

elasticmachine commented Mar 6, 2019

chandlerprall commented Mar 6, 2019

elasticmachine commented Mar 6, 2019

elasticmachine commented Mar 6, 2019

chandlerprall left a comment

walterra left a comment

Upgrades EUI to 9.x #32009

Upgrades EUI to 9.x #32009

Conversation

jasonrhodes commented Feb 26, 2019 • edited Loading

Summary

jasonrhodes Feb 26, 2019

Choose a reason for hiding this comment

chandlerprall Feb 26, 2019

Choose a reason for hiding this comment

elasticmachine commented Feb 26, 2019

💔 Build Failed

elasticmachine commented Feb 26, 2019

💔 Build Failed

nreese commented Mar 1, 2019

jasonrhodes commented Mar 1, 2019

azasypkin commented Mar 1, 2019 • edited Loading

elasticmachine commented Mar 1, 2019

💔 Build Failed

chandlerprall commented Mar 1, 2019

jasonrhodes commented Mar 1, 2019

elasticmachine commented Mar 1, 2019

💔 Build Failed

elasticmachine commented Mar 1, 2019

💔 Build Failed

jasonrhodes commented Mar 1, 2019

jasonrhodes commented Mar 4, 2019 • edited Loading

jasonrhodes commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

💔 Build Failed

chandlerprall commented Mar 4, 2019

chandlerprall commented Mar 4, 2019 • edited Loading

chandlerprall commented Mar 4, 2019

elasticmachine commented Mar 6, 2019

💔 Build Failed

chandlerprall commented Mar 6, 2019

elasticmachine commented Mar 6, 2019

💔 Build Failed

elasticmachine commented Mar 6, 2019

💚 Build Succeeded

chandlerprall left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

jasonrhodes commented Feb 26, 2019 •

edited

Loading

azasypkin commented Mar 1, 2019 •

edited

Loading

jasonrhodes commented Mar 4, 2019 •

edited

Loading

chandlerprall commented Mar 4, 2019 •

edited

Loading