Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32022 - Fix table to display name instead of ID #32051

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Feb 26, 2019

Summary

This PR closed #32022 by using the label for the node instead of the value.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience review v7.0.0 [zube]: In Review Feature:Metrics UI Metrics UI feature v8.0.0 v6.7.0 v7.2.0 labels Feb 26, 2019
@simianhacker simianhacker self-assigned this Feb 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 on the fix side of things. #32022 mentioned adding an additional column to show the container IDs as well, will this be added in a different PR?

@simianhacker
Copy link
Member Author

simianhacker commented Feb 27, 2019

@Kerry350 Correct, we are planning on doing something in a follow up PR but only limited to master and 7.x because technically that will be a new feature. The goal of the ID column is to disambiguate the nodes with the same name.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@roncohen
Copy link
Contributor

thanks @simianhacker !

@weltenwort weltenwort added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra UI] Table view should show container names
6 participants