[ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files #31948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
Team:Core
|
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vitalics
suggested changes
Feb 27, 2019
vitalics
reviewed
Feb 27, 2019
vitalics
reviewed
Feb 27, 2019
vitalics
reviewed
Feb 27, 2019
This comment has been minimized.
This comment has been minimized.
|
@azasypkin @vitalics I might have gone a little overboard, but the comments @vitalics left inspired me a little bit and I ended up with a variation on the solution I had previously. Now:
This new structure allows us to have unique |
💚 Build Succeeded |
💚 Build Succeeded |
vitalics
reviewed
Feb 28, 2019
There was a problem hiding this comment.
type system did not work as well since we have a es service(EsProvider in common folder), which returns elasticsearch.Client typedef, but when I was trying to use them someone in code, i faced with any issue
P.S. common services defined in the right way. I suppose it happens because it "iterable". See ftr.d.ts({[name: string]: FnReturnAny})
Resolved by reverting my local changes 😊
vitalics
approved these changes
Feb 28, 2019
💔 Build Failed |
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 28, 2019
…onfig files (elastic#31948) In elastic#31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from elastic#30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.
spalger
pushed a commit
that referenced
this pull request
Feb 28, 2019
…onfig files (#31948) (#32250) In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.
|
7.x/7.1: ba82d02 |
|
Backporting to 7.0 in #32827 |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 9, 2019
…onfig files (elastic#31948) In elastic#31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from elastic#30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests. # Conflicts: # src/functional_test_runner/lib/config/schema.js # test/common/services/es.ts # test/functional/page_objects/index.ts # test/functional/services/apps_menu.js # yarn.lock
spalger
pushed a commit
that referenced
this pull request
Mar 9, 2019
…32827) * [ts] add script to verify that all ts is in a project (#32727) Based on #32705 We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI. * tests typescript migration (#31234) * add typescript support for functional tests * [ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files (#31948) In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests. # Conflicts: # src/functional_test_runner/lib/config/schema.js # test/common/services/es.ts # test/functional/page_objects/index.ts # test/functional/services/apps_menu.js # yarn.lock
spalger
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #31234 there were some extra changes that I've reverted, like use of the
tsconfig-pathspackage to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in thetest/tsconfig.jsonfile, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.