Typescript sample panel action functional plugin #26747

stacey-gammon · 2018-12-06T02:54:56Z

typescripting for functional test plugins

elasticmachine · 2018-12-06T02:54:57Z

Pinging @elastic/kibana-app

elasticmachine · 2018-12-06T21:40:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-12-06T21:52:19Z

hmmm, still failed @spalger, though at a later spot. Screenshot indicates some issues:

Looks like jenkins keeps the whole build archive, maybe that will add some illumination. I thought I had set it up at some point to spit out any browser console errors, though I don't see any of those in the jenkins output. 🤔 Will look more next week!

stacey-gammon · 2018-12-08T19:32:41Z

In one of the other failure groups I see:

Cannot redeclare block-scoped variable 'accessibleClickKeys'.
16:06:02 
16:06:02       2   export const accessibleClickKeys: { [keyCode: number]: string };
16:06:02                        ~~~~~~~~~~~~~~~~~~~
16:06:02 
16:06:02         ../../../../node_modules/@elastic/eui/eui.d.ts:2:16
16:06:02           2   export const accessibleClickKeys: { [keyCode: number]: string };
16:06:02                            ~~~~~~~~~~~~~~~~~~~
16:06:02           'accessibleClickKeys' was also declared here.

Maybe I just need to rebase

elasticmachine · 2018-12-08T20:26:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-14T21:43:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-01-14T21:48:26Z

Same thing, intake fails with:

00:09:42.385 
00:09:42.388 ERROR test/plugin_functional/plugins/kbn_tp_sample_panel_action failed
00:09:42.388       ../../../../node_modules/@elastic/eui/eui.d.ts:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: EuiButtonPropsForButtonOrLink, ButtonIconSide, ButtonColor, ButtonSize, EuiButton, ButtonIconColor, EuiButtonIcon, EmptyButtonIconSide, EmptyButtonColor, EmptyButtonSizes, EmptyButtonFlush, EuiButtonEmpty
00:09:42.390 
00:09:42.396       1 declare module '@elastic/eui' {
00:09:42.396         ~~~~~~~
00:09:42.398 
00:09:42.398         node_modules/@elastic/eui/src/components/button/index.d.ts:4:1
00:09:42.399           4 import { SFC, ButtonHTMLAttributes, AnchorHTMLAttributes, MouseEventHandler } from 'react';
00:09:42.399             ~~~~~~
00:09:42.413           Conflicts are in this file.
00:09:42.413 
00:09:42.414       ../../../../node_modules/@elastic/eui/eui.d.ts:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: EuiContextMenuPanelHeightChangeHandler, EuiContextMenuPanelTransitionType, EuiContextMenuPanelTransitionDirection, EuiContextMenuPanelShowPanelCallback, EuiContextMenuPanel, EuiContextMenuItemIcon, EuiContextMenuItem, EuiContextMenuPanelId, EuiContextMenuPanelItemDescriptor, EuiContextMenuProps, EuiContextMenu
00:09:42.417 
00:09:42.417       1 declare module '@elastic/eui' {
00:09:42.417         ~~~~~~~
00:09:42.418 
00:09:42.418         node_modules/@elastic/eui/src/components/context_menu/index.d.ts:3:1
00:09:42.418           3 import {
00:09:42.419             ~~~~~~
00:09:42.419           Conflicts are in this file.
00:09:42.420 
00:09:42.420       ../../../../node_modules/@elastic/eui/eui.d.ts:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: EuiModal, EuiModalBody, EuiModalFooter, EuiModalHeader, EuiModalHeaderTitle, EUI_MODAL_CONFIRM_BUTTON, EUI_MODAL_CANCEL_BUTTON, EuiConfirmModal
00:09:42.422 
00:09:42.422       1 declare module '@elastic/eui' {
00:09:42.422         ~~~~~~~
00:09:42.422 
00:09:42.423         node_modules/@elastic/eui/src/components/modal/index.d.ts:4:1
00:09:42.424           4 import { ReactNode, SFC, HTMLAttributes } from 'react';
00:09:42.424             ~~~~~~
00:09:42.425           Conflicts are in this file.
00:09:42.426 
00:09:42.426       ../../../../node_modules/@elastic/eui/eui.d.ts:1:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: EuiPage, EuiPageHeader, EuiPageHeaderSection, EuiPageBody, EuiPageContentPaddingSize, EuiPageContentVerticalPosition, EuiPageContentHorizontalPosition, EuiPageContent, EuiPageContentBody, EuiPageContentHeader, EuiPageContentHeaderSection, EuiPageSideBar
00:09:42.428 
00:09:42.429       1 declare module '@elastic/eui' {
00:09:42.429         ~~~~~~~
00:09:42.431 
00:09:42.431         node_modules/@elastic/eui/src/components/page/index.d.ts:4:1
00:09:42.431           4 import { SFC, HTMLAttributes } from 'react';
00:09:42.434             ~~~~~~
00:09:42.434           Conflicts are in this file.
00:09:42.434

Looks like there are duplicate EUI includes

stacey-gammon · 2019-01-15T19:21:35Z

The error that occurs above during the typeCheck tasks goes away if I remove the added code in projects.ts:

  ...glob
    .sync('test/plugin_functional/plugins/*/tsconfig.json', { cwd: REPO_ROOT })
    .map(path => new Project(resolve(REPO_ROOT, path))),

... I forget why I added that. On a recommendation from @spalger to fix a problem that I now can't remember. I'll remove and see what errors I get. I thought maybe failure to import the ui/public types but it seems okay now (though could also be it's cached and the errors have been recalculated yet in my VSCode).

elasticmachine · 2019-01-15T20:42:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

… at it

elasticmachine · 2019-01-15T21:02:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-15T22:19:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-27T03:53:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger · 2019-02-27T23:43:22Z

@mattkime since this is based on #31948 we need to merge that before this, and since we're going to need to rebase for that and a number of the changes in the PR are from that one I'd like to take care of it before reviewing if you don't mind. I believe that we're really close to merging anyway.

elasticmachine · 2019-03-04T19:33:08Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

mattkime · 2019-03-05T21:09:27Z

retest

elasticmachine · 2019-03-05T21:54:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T22:04:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

mattkime · 2019-03-05T22:09:36Z

wow, i think multiple ci sessions were running at once creating a reporting race condition.

mattkime · 2019-03-05T22:09:43Z

retest

elasticmachine · 2019-03-05T22:56:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

mattkime · 2019-03-06T00:02:58Z

retest

mattkime · 2019-03-06T01:09:52Z

retest

elasticmachine · 2019-03-06T02:02:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

mattkime · 2019-03-06T02:07:29Z

package.json

@@ -88,8 +89,7 @@
      "**/@types/*/**",
      "**/grunt-*",
      "**/grunt-*/**",
-      "x-pack/typescript",
-      "kbn_tp_*/**"
+      "x-pack/typescript"


@mistic Wanted to get your opinion on this change. Typescript was giving @spalger and I some trouble and this seemed necessary to resolve it. Is there anything we might have inadvertently broke?

(sorry for the ping @ThiagoTcorsi)

@mattkime as far as I remembered, in the past we had the need to add "kbn_tp_*/**" to the yarn workspaces nohoist feature in order to have the node_modules installed for the kibana/test/plugin_functional/plugins, otherwise those plugins during the tests can't read the node_modules they declare from the dll bundle

@mistic so if it passes, its good?

@mattkime well maybe I'm missing something here, but what have changed in order to avoid the dependencies for that plugins being hoisting by the yarn workspaces?

mattkime · 2019-03-06T02:11:05Z

retest

elasticmachine · 2019-03-06T02:57:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-06T03:05:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-03-06T21:25:48Z

Removed my request for review for the time being, let me know if you want me to take a look at something specific before CI is green

mattkime · 2019-03-07T00:18:34Z

retest

elasticmachine · 2019-03-07T01:11:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…pescript-sample-panel-action

elasticmachine · 2019-03-20T17:58:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-03-20T19:22:02Z

Closing this in favor of https://github.com/elastic/kibana/pull/33602/files where I hopefully cherrypicked the necessary changes to get this to build. I think I messed up the merge with master, and there are so many commits it's hard to follow exactly what was necessary.

stacey-gammon added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 6, 2018

stacey-gammon force-pushed the 2018-12-05-typescript-sample-panel-action branch from 3a77437 to 07fd3db Compare December 6, 2018 02:55

stacey-gammon requested review from timroes and ppisljar December 6, 2018 02:55

stacey-gammon force-pushed the 2018-12-05-typescript-sample-panel-action branch 2 times, most recently from 3a440fc to 8bf023f Compare December 6, 2018 20:49

elastic deleted a comment from elasticmachine Dec 6, 2018

stacey-gammon force-pushed the 2018-12-05-typescript-sample-panel-action branch from 8bf023f to 384b9ac Compare December 8, 2018 19:33

stacey-gammon mentioned this pull request Jan 3, 2019

Support typescript in functional sample plugins #27979

Closed

stacey-gammon force-pushed the 2018-12-05-typescript-sample-panel-action branch from 384b9ac to defac5e Compare January 14, 2019 21:08

stacey-gammon added 3 commits January 15, 2019 15:49

Typescript sample panel action functional plugin

0054b84

Fix config files

278ea40

Try to bypass type check warnings and upgrade eui component while I’m…

df63e00

… at it

stacey-gammon force-pushed the 2018-12-05-typescript-sample-panel-action branch from e48279f to df63e00 Compare January 15, 2019 20:49

update yarn

9de6d1e

stacey-gammon mentioned this pull request Jan 15, 2019

Exclude node modules from tsconfig.json #28789

Closed

Need to match the eui version of kibana to avoid type check conflicts.

fe432f7

not passing typecheck but partial progress

37a1ad7

mattkime added 2 commits March 4, 2019 16:36

Merge branch 'master' into 2018-12-05-typescript-sample-panel-action

34e2558

remove nohoist entry, add skipLibCheck to package

92d2c36

mattkime reviewed Mar 6, 2019

View reviewed changes

spalger removed their request for review March 6, 2019 21:24

Merge branch 'master' into 2018-12-05-typescript-sample-panel-action

50d5ff6

mattkime requested a review from spalger March 7, 2019 16:24

Merge branch 'master' of github.com:elastic/kibana into 2018-12-05-ty…

66e3385

…pescript-sample-panel-action

stacey-gammon closed this Mar 20, 2019

GISScience mentioned this pull request Oct 25, 2019

custom plugin with typescript support works fine in development environment but build fails with yarn build #49269

Closed

Typescript sample panel action functional plugin #26747

Typescript sample panel action functional plugin #26747

Conversation

stacey-gammon commented Dec 6, 2018

elasticmachine commented Dec 6, 2018

elasticmachine commented Dec 6, 2018

💔 Build Failed

stacey-gammon commented Dec 6, 2018

stacey-gammon commented Dec 8, 2018

elasticmachine commented Dec 8, 2018

💔 Build Failed

elasticmachine commented Jan 14, 2019

💔 Build Failed

stacey-gammon commented Jan 14, 2019

stacey-gammon commented Jan 15, 2019

elasticmachine commented Jan 15, 2019

💔 Build Failed

elasticmachine commented Jan 15, 2019

💔 Build Failed

elasticmachine commented Jan 15, 2019

💔 Build Failed

elasticmachine commented Feb 27, 2019

💚 Build Succeeded

spalger commented Feb 27, 2019

elasticmachine commented Mar 4, 2019

💔 Build Failed

mattkime commented Mar 5, 2019

elasticmachine commented Mar 5, 2019

💚 Build Succeeded

elasticmachine commented Mar 5, 2019

💔 Build Failed

mattkime commented Mar 5, 2019

mattkime commented Mar 5, 2019

elasticmachine commented Mar 5, 2019

💔 Build Failed

mattkime commented Mar 6, 2019

mattkime commented Mar 6, 2019

elasticmachine commented Mar 6, 2019

💔 Build Failed

mattkime Mar 6, 2019 • edited by spalger Loading

Choose a reason for hiding this comment

mistic Mar 6, 2019

Choose a reason for hiding this comment

mattkime Mar 7, 2019

Choose a reason for hiding this comment

mistic Mar 7, 2019

Choose a reason for hiding this comment

mattkime commented Mar 6, 2019

elasticmachine commented Mar 6, 2019

💔 Build Failed

elasticmachine commented Mar 6, 2019

💔 Build Failed

spalger commented Mar 6, 2019

mattkime commented Mar 7, 2019

elasticmachine commented Mar 7, 2019

💚 Build Succeeded

elasticmachine commented Mar 20, 2019

💔 Build Failed

stacey-gammon commented Mar 20, 2019

mattkime Mar 6, 2019 •

edited by spalger

Loading