-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript functional test runner improvements #32116
Comments
Personally, I strongly dislike anything that rewrites import statements and it's something we're trying hard to get rid of in webpack because we find it really hard to know where the code you're actually importing lives. In other cases though it is really nice to have a global namespace that you can store things that are used all over the place, kind of like a node_module, which we have packages for. I did this in #31948 with the |
Agreed with @spalger about How provide some data in the component? Model is a entity with predefined values(e.g. which data should be provided). E.g.(or something like this) namespace VisualBuilder {
interface MarkdownModel extends Model {
foo: 'foo',
bar: 'bar',
}
interface TimeSeriesModel extends Model {
baz: 'baz'
}
} |
I personally prefer using services for reusable components, like the |
Describe the feature:
I suppose that time to describe typescript supporting and paths system, since it possible to faced with path hell like
../../../../myModule/myFile
Describe a specific use case for the feature:
let's describe all changes that could be approved by platform and QA teams. Here the list of changes:
test
folder as root (also probably includefunctional_test_runner
folder which locates insrc
directory)In this case in
some_test.ts
file first line(after the license of course 😊) could be like thator new typings from #31948:
As for me it's more simplify and understandable than this line
Also, I attached current progress about tests and typescript:
#31948 #32038 #31234
Update: One more proposal is extending tslint from root for disabling
export default
(any tests are default exporting functions and better solution is disable this rule)The text was updated successfully, but these errors were encountered: