Pass global filters & queries to coordinate maps vis. #30595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
commented
Feb 8, 2019
lukeelmers
commented
Feb 8, 2019
src/legacy/core_plugins/tile_map/public/coordinate_maps_visualization.js
Outdated
Show resolved
Hide resolved
lukeelmers
requested review from
timroes,
ppisljar,
flash1293 and
thomasneirynck
lukeelmers
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ppisljar
requested changes
Feb 11, 2019
src/legacy/core_plugins/tile_map/public/coordinate_maps_visualization.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/tile_map/public/coordinate_maps_visualization.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
lukeelmers
force-pushed
the
fix/data-bounds
branch
from
9cd4244 to
bbfc7ae
Compare
|
@ppisljar Pushed some updates w/ notes. Lmk what you think. |
lukeelmers
commented
Feb 11, 2019
| * under the License. | ||
| */ | ||
|
|
||
| export { queryGeohashBounds } from './query_geohash_bounds'; |
There was a problem hiding this comment.
Added a new utils directory to visualize/loader -- I think this is something we will be able to make use of elsewhere, e.g. extracting some of the field-formatter specific stuff from pipeline_helpers and moving it here
lukeelmers
commented
Feb 11, 2019
| @@ -172,7 +168,7 @@ export function CoordinateMapsVisualizationProvider(Notifier, Private) { | |||
| tooltipFormatter: this._geoJsonFeatureCollectionAndMeta ? boundTooltipFormatter : null, | |||
| mapType: newParams.mapType, | |||
| isFilteredByCollar: this._isFilteredByCollar(), | |||
| fetchBounds: this.getGeohashBounds.bind(this), | |||
| fetchBounds: () => this.vis.API.getGeohashBounds(), // TODO: Remove this (elastic/kibana#30593) | |||
There was a problem hiding this comment.
I don't believe it is necessary to pass this.vis to the function here, as it is already available in embedded_visualize_handler and should be the same object, but let me know if for some reason this is an incorrect assumption.
This comment has been minimized.
This comment has been minimized.
|
Code LGTM! 👍 |
flash1293
approved these changes
Feb 13, 2019
ppisljar
approved these changes
Feb 13, 2019
|
retest |
💔 Build Failed |
lukeelmers
force-pushed
the
fix/data-bounds
branch
from
1979add to
27153c1
Compare
This comment has been minimized.
This comment has been minimized.
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
These failures would be fixed by a merge with master |
lukeelmers
force-pushed
the
fix/data-bounds
branch
from
c73d60d to
5ac4368
Compare
💚 Build Succeeded |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 15, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 15, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 15, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 15, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 15, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23261.
Summary
When you click to fit coordinate map data to the
geo_bounding_box, the vis makes a call to ES usingsearchSourceto retrieve the bounds for that query. Everything worked fine with filters applied in the appState, but globalState filters & queries were not being added, and the vis did not have access to them.After some discussions with @ppisljar, @timroes, and @flash1293, we decided that, for the time being, we'll work around this limitation by attaching global queries/filters to the vis object inside of
embedded_visualize_handler, so that they can be accessed & added tosearchSourcewithin the visualization itself.This is not a long-term solution, and it is something we intend to remove in the future by looking for ways to remove
searchSourcefrom the map vis entirely: #30593.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility