Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove searchSource from tile_map visualization #30593

Closed
lukeelmers opened this issue Feb 8, 2019 · 2 comments
Closed

Remove searchSource from tile_map visualization #30593

lukeelmers opened this issue Feb 8, 2019 · 2 comments
Assignees
Labels
Feature:Coordinate Map Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Feb 8, 2019

Right now, coordinate_maps_visualization.js uses searchSource to query for geohash bounds whenever the "Fit to bounds" map icon is clicked.

Ideally visualizations should not be using searchSource at all, and should only be relying on the dataLoader to pass them all of the information they need.

This is the only vis type I am aware of that's using searchSource from within the vis itself, and it has forced us to add some hacky workarounds for passing global query/filter state down to the vis (e.g. #30595).

Goals for this work would be:

  1. Implement a solution to replace getGeohashBounds() in coordinate_maps_visualization.js, removing searchSource and managing it outside of the vis.
  2. Remove the global state data that we are tacking on to the vis object in embedded_visualize_handler. This was a one-off solution to a bug affecting the tile_map vis ("Fit Data Bounds" neglects filter settings #23261).
@lukeelmers lukeelmers added Feature:Coordinate Map Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@ppisljar ppisljar added :AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@alexh97 alexh97 assigned alexh97 and lukeelmers and unassigned alexh97 May 5, 2020
@lukeelmers
Copy link
Member Author

closing as this has already been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Coordinate Map Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Development

No branches or pull requests

4 participants