[Security Solution] - Update codeowners #202046
Conversation
michaelolo24
added
release_note:skip
michaelolo24
requested review from
angorayc,
yctercero,
PhilippeOberti,
a team,
nikitaindik and
nkhristinin
and removed request for
yctercero
.github/CODEOWNERS
Outdated
| /x-pack/plugins/security_solution_serverless/public/upselling/pages/threat_intelligence_paywall.tsx @elastic/security-threat-hunting-investigations | ||
| /x-pack/plugins/security_solution/public/common/mock/mock_timeline_control_columns.tsx @elastic/security-threat-hunting-investigations | ||
| /x-pack/plugins/security_solution/public/common/components/exit_full_screen @elastic/security-threat-hunting-investigations | ||
| /x-pack/plugins/security_solution/public/app/home/template_wrapper/timeline/index.tsx @elastic/security-threat-hunting-investigations |
There was a problem hiding this comment.
we could the x-pack/plugins/security_solution/public/app/home/template_wrapper/timeline folder here instead of the single index.tsx file within?
There was a problem hiding this comment.
Yep, will update!
💚 Build Succeeded
Metrics [docs]
|
.github/CODEOWNERS
Outdated
| @@ -1503,6 +1503,7 @@ packages/kbn-monaco/src/esql @elastic/kibana-esql | |||
| /x-pack/test_serverless/**/test_suites/**/ml/ @elastic/ml-ui | |||
| /x-pack/test_serverless/**/test_suites/common/management/transforms/ @elastic/ml-ui | |||
| /x-pack/test/api_integration/services/ml.ts @elastic/ml-ui | |||
| /x-pack/plugins/security_solution/public/common/components/ml @elastic/ml-ui | |||
There was a problem hiding this comment.
The ML UI team don't own the code in this folder - the components are part of the security solution. This line should just be removed I think as this path is already in place
x-pack/plugins/security_solution @elastic/security-solution
There was a problem hiding this comment.
Hey @peteharverson - thanks for this note! Yes, we were trying to add more specificity for the sub folders as @elastic/security-solution comprises a significant number of teams now, so someone may have approval rights that doesn't necessarily have the right context. Is there any sub team you would recommend for ownership of this folder or is the security solution the best bet here?
There was a problem hiding this comment.
Sorry, I don't know which is the best security sub-team to own this one. Might be best just to put it to @elastic/security-solution.
There was a problem hiding this comment.
Yea, no worries. Thanks!
nikitaindik
requested review from
banderror
and removed request for
nikitaindik
As part of the EUI update work here: elastic#199715, we've been asked to more specifically identify files owned by sub teams of security solution. This is an initial pass at that work. Please let me know if any of the files identified for your team are innaccurate
As part of the EUI update work here: elastic#199715, we've been asked to more specifically identify files owned by sub teams of security solution. This is an initial pass at that work. Please let me know if any of the files identified for your team are innaccurate
As part of the EUI update work here: elastic#199715, we've been asked to more specifically identify files owned by sub teams of security solution. This is an initial pass at that work. Please let me know if any of the files identified for your team are innaccurate
As part of the EUI update work here: #199715, we've been asked to more specifically identify files owned by sub teams of security solution. This is an initial pass at that work. Please let me know if any of the files identified for your team are innaccurate