Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/streams-program-team #203180

Merged

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 5, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

2 plugin(s) are going to be relocated:

Id Target folder
@kbn/streams-app-plugin x-pack/solutions/observability/plugins/streams_app
@kbn/streams-plugin x-pack/solutions/observability/plugins/streams
Updated references
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/observability/plugins/streams/jest.config.js
./x-pack/solutions/observability/plugins/streams_app/jest.config.js
./yarn.lock
Updated relative paths
x-pack/solutions/observability/plugins/streams/jest.config.js:10
x-pack/solutions/observability/plugins/streams/tsconfig.json:2
x-pack/solutions/observability/plugins/streams/tsconfig.json:7
x-pack/solutions/observability/plugins/streams_app/jest.config.js:10
x-pack/solutions/observability/plugins/streams_app/tsconfig.json:2
x-pack/solutions/observability/plugins/streams_app/tsconfig.json:7
Script errors

Copy link
Contributor

github-actions bot commented Dec 5, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-streams-program-team branch 2 times, most recently from 8f291e4 to d8817bb Compare December 10, 2024 14:41
@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc backport:skip This commit does not require backporting backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 10, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 10, 2024 16:04
@gsoldevila gsoldevila requested review from a team as code owners December 10, 2024 16:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Dec 10, 2024
@gsoldevila gsoldevila enabled auto-merge (squash) December 10, 2024 16:12
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-streams-program-team branch from 5404242 to 70bb063 Compare December 11, 2024 05:54
@gsoldevila gsoldevila merged commit 9bec521 into elastic:main Dec 11, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12271912991

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
streamsApp 4 3 -1

Total ESLint disabled count

id before after diff
streamsApp 6 5 -1

History

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 11, 2024

Backport created manually: #203731

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 203180

Questions ?

Please refer to the Backport tool documentation

flash1293 added a commit that referenced this pull request Dec 11, 2024
…/streams-program-team (#203731)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
@elastic/streams-program-team](#203180)

Co-authored-by: Gerard Soldevila <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…ams-program-team` (elastic#203180)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> This PR has been auto-generated.
> Do not attempt to push any changes unless you know what you are doing.
> Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.




#### 2 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/streams-app-plugin` |
`x-pack/solutions/observability/plugins/streams_app` |
| `@kbn/streams-plugin` |
`x-pack/solutions/observability/plugins/streams` |


<details>
<summary>Updated references</summary>

```
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/observability/plugins/streams/jest.config.js
./x-pack/solutions/observability/plugins/streams_app/jest.config.js
./yarn.lock
```
</details>
<details>
<summary>Updated relative paths</summary>

```
x-pack/solutions/observability/plugins/streams/jest.config.js:10
x-pack/solutions/observability/plugins/streams/tsconfig.json:2
x-pack/solutions/observability/plugins/streams/tsconfig.json:7
x-pack/solutions/observability/plugins/streams_app/jest.config.js:10
x-pack/solutions/observability/plugins/streams_app/tsconfig.json:2
x-pack/solutions/observability/plugins/streams_app/tsconfig.json:7
```
</details>
<details>
<summary>Script errors</summary>

```

```
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants