Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` #202840

gsoldevila · 2024-12-03T23:33:27Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

1 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/osquery-plugin`	`x-pack/platform/plugins/shared/osquery`

1 package(s) are going to be relocated:

Id	Target folder
`@kbn/avc-banner`	`src/platform/packages/shared/kbn-avc-banner`

Updated references

./.buildkite/scripts/pipelines/security_solution_quality_gate/edr_workflows/mki_security_solution_defend_workflows_osquery.sh
./.buildkite/scripts/steps/code_generation/osquery_codegen.sh
./.buildkite/scripts/steps/functional/osquery_cypress.sh
./.buildkite/scripts/steps/functional/osquery_cypress_burn.sh
./.buildkite/scripts/steps/functional/security_serverless_osquery.sh
./.buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh
./.eslintrc.js
./.github/codeql/codeql-config.yml
./.gitignore
./.i18nrc.json
./docs/developer/plugin-list.asciidoc
./oas_docs/scripts/merge_ess_oas.js
./oas_docs/scripts/merge_serverless_oas.js
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/shared/kbn-avc-banner/jest.config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/plugins/shared/osquery/cypress/README.md
./x-pack/platform/plugins/shared/osquery/jest.config.js
./x-pack/plugins/security_solution/docs/openapi/README.md
./yarn.lock

Updated relative paths

src/platform/packages/shared/kbn-avc-banner/jest.config.js:12
src/platform/packages/shared/kbn-avc-banner/tsconfig.json:2
x-pack/platform/plugins/shared/osquery/cypress/README.md:104
x-pack/platform/plugins/shared/osquery/cypress/README.md:110
x-pack/platform/plugins/shared/osquery/cypress/cypress_base.config.ts:28
x-pack/platform/plugins/shared/osquery/cypress/cypress_base.config.ts:36
x-pack/platform/plugins/shared/osquery/cypress/cypress_base.config.ts:39
x-pack/platform/plugins/shared/osquery/cypress/reporter_config.json:6
x-pack/platform/plugins/shared/osquery/cypress/reporter_config.json:8
x-pack/platform/plugins/shared/osquery/cypress/tasks/archiver.ts:25
x-pack/platform/plugins/shared/osquery/cypress/tsconfig.json:12
x-pack/platform/plugins/shared/osquery/cypress/tsconfig.json:2
x-pack/platform/plugins/shared/osquery/cypress/tsconfig.json:25
x-pack/platform/plugins/shared/osquery/cypress/tsconfig.json:8
x-pack/platform/plugins/shared/osquery/jest.config.js:10
x-pack/platform/plugins/shared/osquery/package.json:10
x-pack/platform/plugins/shared/osquery/package.json:13
x-pack/platform/plugins/shared/osquery/package.json:16
x-pack/platform/plugins/shared/osquery/package.json:18
x-pack/platform/plugins/shared/osquery/package.json:19
x-pack/platform/plugins/shared/osquery/package.json:20
x-pack/platform/plugins/shared/osquery/scripts/openapi/bundle.js:8
x-pack/platform/plugins/shared/osquery/scripts/openapi/generate.js:8
x-pack/platform/plugins/shared/osquery/scripts/schema_formatter/ecs.js:8
x-pack/platform/plugins/shared/osquery/scripts/schema_formatter/osquery.js:8
x-pack/platform/plugins/shared/osquery/tsconfig.json:14
x-pack/platform/plugins/shared/osquery/tsconfig.json:2
x-pack/platform/plugins/shared/osquery/tsconfig.json:20

Script errors

Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/cypress/README.md:104
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/cypress/README.md:110
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:19
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/package.json:20
Cannot replace multiple occurrences of "../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/cypress/README.md:104
Cannot replace multiple occurrences of "../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/x-pack/platform/plugins/shared/osquery/cypress/README.md:110

github-actions · 2024-12-03T23:33:42Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-04T08:26:13Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-04T08:26:14Z

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

tomsonpl · 2024-12-05T14:25:18Z

/ci

tomsonpl · 2024-12-06T08:34:15Z

Hey @gsoldevila 👋 Thanks for putting in the effort! Could you clarify something for me? Osquery is being moved to platform because it’s utilized in both Security and Observability, correct? If that’s the case, what happens with the imports that Osquery currently has from security_solution and timelines?
Does this PR address the issue of invalid imports?

gsoldevila · 2024-12-06T11:58:04Z

Hey @gsoldevila 👋 Thanks for putting in the effort! Could you clarify something for me? Osquery is being moved to platform because it’s utilized in both Security and Observability, correct? If that’s the case, what happens with the imports that Osquery currently has from security_solution and timelines? Does this PR address the issue of invalid imports?

Ideally this would need to be addressed, for the time being I added an exception in
https://github.com/elastic/kibana/blob/main/.eslintrc.js#L2006,L2007
See related discussion

…-fix'

stephmilovic

Security solution changes LGTM

kc13greiner

Changes to .github/codeql/codeql-config.yml lgtm!

tomsonpl · 2024-12-11T14:21:06Z

@gsoldevila - who should continue working on this PR, should there be someone from Osquery team assigned, or you're still in the process of adjusting the PR?

…rkflows # Conflicts: # .github/CODEOWNERS

…curity-defend-workflows' into kbn-team-1309-move-kibana-security-defend-workflows

…rkflows # Conflicts: # .github/CODEOWNERS

tomsonpl

Defend Workflows code changes LGTM, I pushed a few commits updating paths so the Osquery cypress tests work fine again 👍

…ocs'

elasticmachine · 2024-12-13T09:45:27Z

💚 Build Succeeded

Buildkite Build
Commit: 3665725

Metrics [docs]

✅ unchanged

History

💚 Build #259901 succeeded 32a8895
💔 Build #259803 failed 2ed1eba
💔 Build #258821 failed b0f36f3
💔 Build #257500 failed 264dcea
💔 Build #257491 failed 2cb6320
💔 Build #257462 failed 6a1e875

ashokaditya

Thanks for talking on the huge set of changes. Appreciate the effort. 🚀

kibanamachine · 2024-12-13T14:40:31Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12317668339

kibanamachine · 2024-12-13T14:40:34Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12317668436

kibanamachine · 2024-12-13T14:45:34Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202840

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-12-13T14:45:36Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - Sustainable Kibana Architecture: Move modules owned by `@elastic/security-scalability` (#202849) - [Synthetics] migrate first set of tests (#198950) - [Obs UX Management] Migrate leftover code owner !! (#203814) - Sustainable Kibana Architecture: Add `scripts/relocate` CLI (beta) (#203803) - [UA] `kibana-core` ownership (#203410) - [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202840

Questions ?

Please refer to the Backport tool documentation

…rity-defend-workflows` (elastic#202840) (cherry picked from commit 42af4e6) # Conflicts: # .github/CODEOWNERS # oas_docs/scripts/merge_serverless_oas.js

gsoldevila · 2024-12-13T15:04:28Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…c/security-defend-workflows` (#202840) (#204232) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` (#202840)](#202840)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

gsoldevila marked this pull request as ready for review December 4, 2024 08:26

gsoldevila requested review from a team as code owners December 4, 2024 08:26

gsoldevila requested review from ashokaditya and paul-tavares December 4, 2024 08:26

paul-tavares requested review from tomsonpl and removed request for paul-tavares December 4, 2024 16:37

gsoldevila force-pushed the kbn-team-1309-move-kibana-security-defend-workflows branch from 6a1e875 to 2cb6320 Compare December 5, 2024 14:58

gsoldevila added 2 commits December 10, 2024 16:09

Relocating module @kbn/avc-banner

ff009cf

Relocating module @kbn/osquery-plugin

73ec807

gsoldevila force-pushed the kbn-team-1309-move-kibana-security-defend-workflows branch from 264dcea to 73ec807 Compare December 10, 2024 15:10

gsoldevila requested a review from a team as a code owner December 10, 2024 15:10

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

b0f36f3

…-fix'

stephmilovic approved these changes Dec 10, 2024

View reviewed changes

kc13greiner self-requested a review December 10, 2024 17:31

kc13greiner approved these changes Dec 10, 2024

View reviewed changes

Ikuni17 approved these changes Dec 10, 2024

View reviewed changes

tomsonpl and others added 5 commits December 12, 2024 14:01

update paths

c191210

Merge branch 'main' into kbn-team-1309-move-kibana-security-defend-wo…

93f7576

…rkflows # Conflicts: # .github/CODEOWNERS

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

2ed1eba

fix1

a873409

Merge remote-tracking branch 'gsoldevila/kbn-team-1309-move-kibana-se…

32a8895

…curity-defend-workflows' into kbn-team-1309-move-kibana-security-defend-workflows

tomsonpl marked this pull request as draft December 12, 2024 15:33

tomsonpl marked this pull request as ready for review December 12, 2024 19:33

tomsonpl marked this pull request as draft December 12, 2024 19:33

tomsonpl marked this pull request as ready for review December 13, 2024 07:43

Merge branch 'main' into kbn-team-1309-move-kibana-security-defend-wo…

96012f7

…rkflows # Conflicts: # .github/CODEOWNERS

tomsonpl approved these changes Dec 13, 2024

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

3665725

…ocs'

tomsonpl enabled auto-merge (squash) December 13, 2024 10:13

ashokaditya approved these changes Dec 13, 2024

View reviewed changes

dokmic approved these changes Dec 13, 2024

View reviewed changes

tomsonpl merged commit 42af4e6 into elastic:main Dec 13, 2024
8 checks passed

kibanamachine added the v9.0.0 label Dec 13, 2024

gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 13, 2024

gsoldevila mentioned this pull request Dec 13, 2024

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-defend-workflows (#202840) #204232

Merged

kibanamachine added the v8.18.0 label Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` #202840

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` #202840

gsoldevila commented Dec 3, 2024 •

edited by kibanamachine

Loading

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

tomsonpl commented Dec 5, 2024

tomsonpl commented Dec 6, 2024

gsoldevila commented Dec 6, 2024

stephmilovic left a comment

kc13greiner left a comment

tomsonpl commented Dec 11, 2024

tomsonpl left a comment

elasticmachine commented Dec 13, 2024

ashokaditya left a comment

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 13, 2024

gsoldevila commented Dec 13, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-defend-workflows #202840

Sustainable Kibana Architecture: Move modules owned by @elastic/security-defend-workflows #202840

Conversation

gsoldevila commented Dec 3, 2024 • edited by kibanamachine Loading

Summary

1 plugin(s) are going to be relocated:

1 package(s) are going to be relocated:

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

tomsonpl commented Dec 5, 2024

tomsonpl commented Dec 6, 2024

gsoldevila commented Dec 6, 2024

stephmilovic left a comment

Choose a reason for hiding this comment

kc13greiner left a comment

Choose a reason for hiding this comment

tomsonpl commented Dec 11, 2024

tomsonpl left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 13, 2024

💚 Build Succeeded

Metrics [docs]

History

ashokaditya left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 13, 2024

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Dec 13, 2024

💔 All backports failed

Manual backport

Questions ?

gsoldevila commented Dec 13, 2024

💚 All backports created successfully

Questions ?

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` #202840

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-defend-workflows` #202840

gsoldevila commented Dec 3, 2024 •

edited by kibanamachine

Loading