Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Embeddable] Fix display options regressions #201998

Merged
merged 5 commits into from
Nov 29, 2024
Merged

[Lens][Embeddable] Fix display options regressions #201998

merged 5 commits into from
Nov 29, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Nov 27, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #201829

This PR fixes a regression introduced with #178965 where specific visualization display options were ignored in the embeddable context.
Additional tests have been added to avoid further regressions in the future.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 27, 2024
@dej611
Copy link
Contributor Author

dej611 commented Nov 27, 2024

/ci

@dej611 dej611 marked this pull request as ready for review November 27, 2024 16:44
@dej611 dej611 requested a review from a team as a code owner November 27, 2024 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611 dej611 enabled auto-merge (squash) November 29, 2024 08:51
@dej611 dej611 merged commit fd589b8 into elastic:main Nov 29, 2024
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / FileDownloadButton not isIcon renders download button with correct href

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +455.0B

History

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12084953112

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2024
@dej611
[Lens][Embeddable] Fix display options regressions (elastic#201998)
35bbd9d 
## Summary

Fixes elastic#201829

This PR fixes a regression introduced with elastic#178965 where specific
visualization display options were ignored in the embeddable context.
Additional tests have been added to avoid further regressions in the
future.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit fd589b8)
@kibanamachine kibanamachine mentioned this pull request Nov 29, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 29, 2024
@kibanamachine @dej611
[8.x] [Lens][Embeddable] Fix display options regressions (#201998) (#…
a9d35ff 
…202294)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens][Embeddable] Fix display options regressions
(#201998)](#201998)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T12:42:09Z","message":"[Lens][Embeddable]
Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes
#201829\r\n\r\nThis PR fixes a regression introduced with #178965 where
specific\r\nvisualization display options were ignored in the embeddable
context.\r\nAdditional tests have been added to avoid further
regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens][Embeddable]
Fix display options
regressions","number":201998,"url":"https://github.com/elastic/kibana/pull/201998","mergeCommit":{"message":"[Lens][Embeddable]
Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes
#201829\r\n\r\nThis PR fixes a regression introduced with #178965 where
specific\r\nvisualization display options were ignored in the embeddable
context.\r\nAdditional tests have been added to avoid further
regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201998","number":201998,"mergeCommit":{"message":"[Lens][Embeddable]
Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes
#201829\r\n\r\nThis PR fixes a regression introduced with #178965 where
specific\r\nvisualization display options were ignored in the embeddable
context.\r\nAdditional tests have been added to avoid further
regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@dej611 @CAWilson94
[Lens][Embeddable] Fix display options regressions (elastic#201998)
78cc659 
## Summary

Fixes elastic#201829

This PR fixes a regression introduced with elastic#178965 where specific
visualization display options were ignored in the embeddable context.
Additional tests have been added to avoid further regressions in the
future.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard][Lens] 8px padding added to some panels
4 participants
@dej611 @elasticmachine @kibanamachine @markov00